Date: Tue, 17 Jul 2018 13:57:53 -0700
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abe7a8891425cdbbeae1e08e94ac4dcb170183452592cf0000000117661a5192a169ce14638397@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1579/405725492@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1579@github.com>
References: <quicwg/base-drafts/issues/1579@github.com>
Subject: Re: [quicwg/base-drafts] Go Back to Single Packet Number Space (#1579)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b4e5851de449_24f92b0e248eaf502571e2";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pTrj3GdJtmTmO5azmu2rlX4DYmo>


----==_mimepart_5b4e5851de449_24f92b0e248eaf502571e2
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

1. Reserve 2 bits per sent packet tracking structure for encryption level. I'd bet whatever structure you have already has 2 free bits.
2. When processing an ACK frame, pass along the encryption level the frame was received in. Use that in your `OnPacketAcked` function to validate.

That logic was a LOT simpler than the logic I have to maintain for framing all my ACKs in the different packet levels right now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1579#issuecomment-405725492
----==_mimepart_5b4e5851de449_24f92b0e248eaf502571e2
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<ol>
<li>Reserve 2 bits per sent packet tracking structure for encryption leve=
l. I'd bet whatever structure you have already has 2 free bits.</li>
<li>When processing an ACK frame, pass along the encryption level the fra=
me was received in. Use that in your <code>OnPacketAcked</code> function =
to validate.</li>
</ol>
<p>That logic was a LOT simpler than the logic I have to maintain for fra=
ming all my ACKs in the different packet levels right now.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/issues/1579#issuecomment-405725492">view it on GitHub</a>,=
 or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkqwaa=
OTgNfqG6m9YF3O9Fd43uSHI7ks5uHk_RgaJpZM4VTfDt">mute the thread</a>.<img sr=
c=3D"https://github.com/notifications/beacon/AWbkq3DLRDUZwiLhqkB-RhTf32wm=
082Cks5uHk_RgaJpZM4VTfDt.gif" height=3D"1" width=3D"1" alt=3D"" /></p>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://assets-cdn.github.com/images/email/message_cards/header.png","avatar_=
image_url":"https://assets-cdn.github.com/images/email/message_cards/avat=
ar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicw=
g/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@niba=
nks in #1579: 1. Reserve 2 bits per sent packet tracking structure for en=
cryption level. I'd bet whatever structure you have already has 2 free bi=
ts.\r\n2. When processing an ACK frame, pass along the encryption level t=
he frame was received in. Use that in your `OnPacketAcked` function to va=
lidate.\r\n\r\nThat logic was a LOT simpler than the logic I have to main=
tain for framing all my ACKs in the different packet levels right now."}]=
,"action":{"name":"View Issue","url":"https://github.com/quicwg/base-draf=
ts/issues/1579#issuecomment-405725492"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/1579#issuecomment=
-405725492",
"url": "https://github.com/quicwg/base-drafts/issues/1579#issuecomment-40=
5725492",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [quicwg/base-drafts] Go Back to Single Packet Number Space =
(#1579)",
"sections": [
{
"text": "",
"activityTitle": "**Nick Banks**",
"activityImage": "https://assets-cdn.github.com/images/email/message_card=
s/avatar.png",
"activitySubtitle": "@nibanks",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \=
"quicwg/base-drafts\",\n\"issueId\": 1579,\n\"IssueComment\": \"{{IssueCo=
mment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"q=
uicwg/base-drafts\",\n\"issueId\": 1579\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/issues/1579#issuecomment-40=
5725492"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 3574294=
85\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5b4e5851de449_24f92b0e248eaf502571e2--