Re: [quicwg/base-drafts] clarify what happens when consuming CIDs excessively (#2428)

Jana Iyengar <notifications@github.com> Fri, 22 February 2019 02:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 51DB8128B01 for <quic-issues@ietfa.amsl.com>; Thu, 21 Feb 2019 18:12:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.002
X-Spam-Level:
X-Spam-Status: No, score=-8.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 94IO2oV6Pria for <quic-issues@ietfa.amsl.com>; Thu, 21 Feb 2019 18:12:45 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F32BA126F72 for <quic-issues@ietf.org>; Thu, 21 Feb 2019 18:12:44 -0800 (PST)
Date: Thu, 21 Feb 2019 18:12:43 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550801563; bh=1Zbf23XqHShrGfYIKPuHZngFVY2YjQrJE5+F4nsyZzU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tSXQb76uRjLNZa7R4lpKqC9ai6/gPNeq4ha87sz2zvXXAR3mjLTOh1ZhBvzngc9ou J/1RIU/qHe6VVTodg+0kDd09R1KfA2ZjLdN1IbK3OebKDkQ7pFzQCH0XvPtuXgcXVs UCHjQbSZ8DLE6KMn2Dh3qcM6YrZsuY6mXGRPJrQc=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab69661849b99baa181bf6df6f3bf29feb839a098a92cf0000000118871c9b92a169ce184361c4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2428/review/206630866@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2428@github.com>
References: <quicwg/base-drafts/pull/2428@github.com>
Subject: Re: [quicwg/base-drafts] clarify what happens when consuming CIDs excessively (#2428)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c6f5a9bb069d_49993fc4bfad45bc170768"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pUW4xiITvI-gNX6NDhnoG7-MAmM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Feb 2019 02:12:47 -0000

janaiyengar approved this pull request.

A few nits, but this looks good to me. That said, this issue will need consensus.

> @@ -961,12 +961,16 @@ cannot expect its peer to store and use all issued connection IDs.
 An endpoint SHOULD ensure that its peer has a sufficient number of available and
 unused connection IDs.  While each endpoint independently chooses how many
 connection IDs to issue, endpoints SHOULD provide and maintain at least eight
-connection IDs.  The endpoint SHOULD do this by always supplying a new
-connection ID when a connection ID is retired by its peer or when the endpoint
-receives a packet with a previously unused connection ID.  Endpoints that
-initiate migration and require non-zero-length connection IDs SHOULD provide
-their peers with new connection IDs before migration, or risk the peer closing
-the connection.
+connection IDs.  The endpoint SHOULD do this by supplying a new connection ID
+when a connection ID is retired by its peer or when the endpoint receives a
+packet with a previously unused connection ID, though it MAY limit the frequency

```suggestion
packet with a previously unused connection ID.  However, it MAY limit the frequency
```

> @@ -961,12 +961,16 @@ cannot expect its peer to store and use all issued connection IDs.
 An endpoint SHOULD ensure that its peer has a sufficient number of available and
 unused connection IDs.  While each endpoint independently chooses how many
 connection IDs to issue, endpoints SHOULD provide and maintain at least eight
-connection IDs.  The endpoint SHOULD do this by always supplying a new
-connection ID when a connection ID is retired by its peer or when the endpoint
-receives a packet with a previously unused connection ID.  Endpoints that
-initiate migration and require non-zero-length connection IDs SHOULD provide
-their peers with new connection IDs before migration, or risk the peer closing
-the connection.
+connection IDs.  The endpoint SHOULD do this by supplying a new connection ID
+when a connection ID is retired by its peer or when the endpoint receives a
+packet with a previously unused connection ID, though it MAY limit the frequency
+or the total number of connection IDs issued for each connection to avoid the
+risk of running out of connection IDs (see {{reset-token}}).
+
+Endpoints that initiate migration and require non-zero-length connection IDs

```suggestion
An endpoint that initiates migration and requires non-zero-length connection IDs
```

> @@ -961,12 +961,16 @@ cannot expect its peer to store and use all issued connection IDs.
 An endpoint SHOULD ensure that its peer has a sufficient number of available and
 unused connection IDs.  While each endpoint independently chooses how many
 connection IDs to issue, endpoints SHOULD provide and maintain at least eight
-connection IDs.  The endpoint SHOULD do this by always supplying a new
-connection ID when a connection ID is retired by its peer or when the endpoint
-receives a packet with a previously unused connection ID.  Endpoints that
-initiate migration and require non-zero-length connection IDs SHOULD provide
-their peers with new connection IDs before migration, or risk the peer closing
-the connection.
+connection IDs.  The endpoint SHOULD do this by supplying a new connection ID
+when a connection ID is retired by its peer or when the endpoint receives a
+packet with a previously unused connection ID, though it MAY limit the frequency
+or the total number of connection IDs issued for each connection to avoid the
+risk of running out of connection IDs (see {{reset-token}}).
+
+Endpoints that initiate migration and require non-zero-length connection IDs
+SHOULD ensure that the pool of connection IDs available to their peers allows

```suggestion
SHOULD ensure that the pool of connection IDs available to its peer allows
```

> @@ -961,12 +961,16 @@ cannot expect its peer to store and use all issued connection IDs.
 An endpoint SHOULD ensure that its peer has a sufficient number of available and
 unused connection IDs.  While each endpoint independently chooses how many
 connection IDs to issue, endpoints SHOULD provide and maintain at least eight
-connection IDs.  The endpoint SHOULD do this by always supplying a new
-connection ID when a connection ID is retired by its peer or when the endpoint
-receives a packet with a previously unused connection ID.  Endpoints that
-initiate migration and require non-zero-length connection IDs SHOULD provide
-their peers with new connection IDs before migration, or risk the peer closing
-the connection.
+connection IDs.  The endpoint SHOULD do this by supplying a new connection ID
+when a connection ID is retired by its peer or when the endpoint receives a
+packet with a previously unused connection ID, though it MAY limit the frequency
+or the total number of connection IDs issued for each connection to avoid the
+risk of running out of connection IDs (see {{reset-token}}).
+
+Endpoints that initiate migration and require non-zero-length connection IDs
+SHOULD ensure that the pool of connection IDs available to their peers allows
+them to use a new connection ID on migration, as the peer will close the

```suggestion
the peer to use a new connection ID on migration, as the peer will close the
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2428#pullrequestreview-206630866