IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)

ianswett <notifications@github.com> Tue, 09 April 2019 20:45 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 759C712044B for <quic-issues@ietfa.amsl.com>; Tue, 9 Apr 2019 13:45:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ibSDcRQBz_WK for <quic-issues@ietfa.amsl.com>; Tue, 9 Apr 2019 13:45:50 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D37CE12043C for <quic-issues@ietf.org>; Tue, 9 Apr 2019 13:45:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=VGjb1/E3+jLYx4x3CzcgecFlgBk=; b=r2+fxAobCX1KEJwI nhnlM450gpXTBo93Q3HMHdUO3gFXwPi9k2+qPfaXaZbLk+B8dIskB61QDsCUnAyr fGYORSNCNaM6VsmAlkonYZr169DKCrENR5jFuaeLMDmWCF2++FQfjp8WJPOXv9Ng MRMJg+a8DWeSo/mpQ80/pmpuOHQ=
Received: by filter0888p1las1.sendgrid.net with SMTP id filter0888p1las1-18538-5CAD047D-8 2019-04-09 20:45:49.172624166 +0000 UTC m=+72665.185448597
Received: from github-lowworker-819f804.cp1-iad.github.net (unknown [192.30.252.44]) by ismtpd0009p1iad2.sendgrid.net (SG) with ESMTP id t29fSoQCTOi1LoxB6p0QdA for <quic-issues@ietf.org>; Tue, 09 Apr 2019 20:45:48.882 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-819f804.cp1-iad.github.net (Postfix) with ESMTP id 0A53036006C for <quic-issues@ietf.org>; Tue, 9 Apr 2019 13:45:49 -0700 (PDT)
Date: Tue, 09 Apr 2019 20:45:49 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf19e90530ebb920e88472d99d18bbd7d28bf84e492cebaba36fd92a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/review/224644596@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cad047d8725_70593f96488d45b448188"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3uX/Bjtf+D9zLklVsjAMZfYMJQ1jELDa1euq zXq7f9GL475f9edVth4YY5rXPNSGCbB6CYneifktTRBDq83eJofN32f8QEu3qeBJkZqSqScnnYJiqw ku6kjeBTj5DiF5oJGU0Nt5CsCy0qTwZMskuLmKqr72lr13IYD9L2DOA5YQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pUiJlzT6WRTXlg6FZ_uqu-NfVV0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Apr 2019 20:45:52 -0000

ianswett commented on this pull request.



> @@ -442,13 +442,17 @@ connections over the same network SHOULD use the previous connection's final
 smoothed RTT value as the resumed connection's initial RTT.  If no previous RTT
 is available, or if the network changes, the initial RTT SHOULD be set to 500ms,
 resulting in a 1 second initial handshake timeout as recommended in
-{{?RFC6298}}. When an acknowledgement is received, a new RTT is computed and the
-timer SHOULD be set for twice the newly computed smoothed RTT.
+{{?RFC6298}}. When the first acknowledgement is received, an RTT is computed and
+the timer SHOULD be set for twice the newly computed RTT.

SG, removed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2590#discussion_r273692311

v2.23.0 | Report a Bug | By Email