Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)

[ianswett <[e-mail]>]

ianswett commented on this pull request.

Thanks, I think this is heading in the right direction.  I'd like it to be cleaner, but this isn't a clean mechanism.

> @@ -699,6 +703,9 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
     largest_acked_packet = max(largest_acked_packet,
                                ack.largest_acked)
 
+    if (from Handshake packet):

```suggestion
    if (ack from Handshake packet):
```

> @@ -699,6 +703,9 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
     largest_acked_packet = max(largest_acked_packet,
                                ack.largest_acked)
 
+    if (from Handshake packet):

Can you add a short comment like "Once the client receives an ACK in a Handshake packet, it knows the server considers its address verified."?

> @@ -823,6 +831,12 @@ Pseudocode for OnLossDetectionTimeout follows:
        // Crypto retransmission timeout.
        RetransmitUnackedCryptoData()
        crypto_count++
+     else if (unverified_client):
+       if (handshake keys available)
+         SendOnePacket()
+       else:
+         SendPaddedPacket()

```suggestion
         SendOnePaddedPacket()
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2281#pullrequestreview-192855977