Re: [quicwg/base-drafts] grease transport parameters (#2873)

Mike Bishop <notifications@github.com> Wed, 07 August 2019 19:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B6871205DC for <quic-issues@ietfa.amsl.com>; Wed, 7 Aug 2019 12:47:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9kMC-aPktuYQ for <quic-issues@ietfa.amsl.com>; Wed, 7 Aug 2019 12:47:32 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1AA541201C9 for <quic-issues@ietf.org>; Wed, 7 Aug 2019 12:47:32 -0700 (PDT)
Date: Wed, 07 Aug 2019 12:47:31 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1565207251; bh=IMmVZ7ZdTUG3ve527+4RhSAqsZ65pso1XuXOowujYZs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yieLUxYqhUClyu1Rr2LJGC/XSI70llP93L7nGZ3nWwF/OrvrK+J0xhy962xs/dW0N XKsa4p49g5hyfrn8f/g6fohWnGbaGv9OxoVUbi/RpvHW75vXAbgTnRDkJvJfO5lO+G g2MQnAGKQQX28p+f3pj1Y8e+l7NF9Mj67Oec29no=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYW47ZTWIKTHP3ZOY53LBOVHEVBNHHBXMLRZE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2873/review/272189375@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2873@github.com>
References: <quicwg/base-drafts/pull/2873@github.com>
Subject: Re: [quicwg/base-drafts] grease transport parameters (#2873)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d4b2ad32652e_4b703fee31acd9604993c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/po4dcWj5LSVeio5zUW2zf-bRbt0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Aug 2019 19:47:34 -0000

MikeBishop requested changes on this pull request.

Need to fix the examples, but otherwise looks good.

> @@ -5536,6 +5545,9 @@ The initial contents of this registry are shown in {{iana-tp-table}}.
 | 0x000e | active_connection_id_limit  | {{transport-parameter-definitions}} |
 {: #iana-tp-table title="Initial QUIC Transport Parameters Entries"}
 
+Additionally, each value of the format `31 * N + 27` for integer values of N
+(that is, `31`, `58`, `85`, ...) MUST NOT be assigned by IANA.

```suggestion
(that is, `27`, `58`, `89`, ...) MUST NOT be assigned by IANA.
```
Your examples are of `31 + N * 27`, I believe....

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2873#pullrequestreview-272189375