Re: [quicwg/base-drafts] Don't apply PTO backoff twice in GetPtoTimeAndSpace() (#3974)

Martin Thomson <notifications@github.com> Thu, 30 July 2020 14:03 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D3AE3A11D1 for <quic-issues@ietfa.amsl.com>; Thu, 30 Jul 2020 07:03:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.008
X-Spam-Level:
X-Spam-Status: No, score=-2.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ywaKehBxKuuB for <quic-issues@ietfa.amsl.com>; Thu, 30 Jul 2020 07:03:00 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C5F0D3A11A1 for <quic-issues@ietf.org>; Thu, 30 Jul 2020 07:02:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=UkGxnFND1/Ot0mxYr88zgo6WCCqrDkyLTXCCMKvXVKs=; b= Hvo/XCoVGSEAdZxpjtXjAsnryyfdBIfbYIabMM9AikZ+MS6x5bWp0FAr8GMaJXKv rySE43ohMlttP8U5uyAuNmKgwEumjdg/rwOcRjx1g1j80VamoD02UFSoc63FKJf6 bMgu25NXyt2aEs5zGLQ6tgnawcpd94zekuVmxV8dR0E=
Received: by filter0850p1iad2.sendgrid.net with SMTP id filter0850p1iad2-14599-5F22D312-6A 2020-07-30 14:02:58.632827594 +0000 UTC m=+60328.682910587
Received: from github-lowworker-6b40fdd.va3-iad.github.net (unknown) by ismtpd0050p1iad1.sendgrid.net (SG) with ESMTP id -dyq6SpRR7mHbmnepWmQhQ for <quic-issues@ietf.org>; Thu, 30 Jul 2020 14:02:58.549 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-6b40fdd.va3-iad.github.net (Postfix) with ESMTP id 65AB7720B17 for <quic-issues@ietf.org>; Thu, 30 Jul 2020 07:02:58 -0700 (PDT)
Date: Thu, 30 Jul 2020 14:02:58 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYYEZNMYCZBSA7IBJV5F22BFEVBNHHCPWZPBM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3974/review/458431092@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3974@github.com>
References: <quicwg/base-drafts/pull/3974@github.com>
Subject: Re: [quicwg/base-drafts] Don't apply PTO backoff twice in GetPtoTimeAndSpace() (#3974)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f22d31264255_7e8d16f8150999"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1++rCBH3hHHS1I3VWc+KuDx+jDoDpm1tI5Cz 02kqbv8DTZMMhI4RJItv24FI5pqQ6J8bCYoUM74VqvcDvaZz7q0pXq3jjyMdAHkNMjrbpZEx+Xh+Ix bJ/Nq8dAAkWghzgiawiaLATAFUnwXPjKJQ/YoAZ6xNyiF3ecR9OMO2SXE1QjBhA+CIoMFXs2bg4kxU g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pokhnzmbPRRblF_6-N1kWDS8ZJE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2020 14:03:07 -0000

@martinthomson commented on this pull request.

I thought that this was intentional, that is, the value is supposed to be:

```
(rtt + 4*rttval + max_ack_delay) << pto_count
```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3974#pullrequestreview-458431092