Re: [quicwg/base-drafts] First tranche of EKR's editorial pass, through 7.3.2 (#2087)

Martin Thomson <notifications@github.com> Sun, 02 December 2018 23:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 19471130DCC for <quic-issues@ietfa.amsl.com>; Sun, 2 Dec 2018 15:19:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 573kHk3F8_F0 for <quic-issues@ietfa.amsl.com>; Sun, 2 Dec 2018 15:19:01 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BBCEC130DBE for <quic-issues@ietf.org>; Sun, 2 Dec 2018 15:19:01 -0800 (PST)
Date: Sun, 02 Dec 2018 15:19:01 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543792741; bh=LLUa7UiUvESN3ErcIX4L/hKpapFkjPuW9i4GP4ft9cY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=l7Sqt2Lmk79LGC8+LXMX6bkiN41irBy2TzqRw7PprGA834VLNqJQrHQsyZqLKPylx EOKR1Qu1WAO2MUH2IrTv8RuZbfYStI+ZC6f32Gm5NC2IVKNdIjhMVfexSF7poNmNUy aAmWzxwgnJphdhNiBDYRRlOCxlDULE4aC35kNvO8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab75316c8e0b90d13ab366f40e7098391d1b24346e92cf00000001181c2a6592a169ce17083377@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2087/review/180583527@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2087@github.com>
References: <quicwg/base-drafts/pull/2087@github.com>
Subject: Re: [quicwg/base-drafts] First tranche of EKR's editorial pass, through 7.3.2 (#2087)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c046865d123_54ac3fe2f9cd45bc16323d9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pphI6_26iFTAqrQQxfHk_pcCUO0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Dec 2018 23:19:03 -0000

martinthomson approved this pull request.



>  operating systems and middleboxes.  QUIC authenticates all of its headers and
-encrypts most of the data it exchanges, including its signaling, to avoid
+encrypts most of the data it exchanges -- including its signaling -- to avoid

I hate em--dashes done this way. 

> @@ -383,7 +383,7 @@ data to a peer.
 ~~~
        o
        | Create Stream (Sending)
-       | Create Bidirectional Stream (Receiving)
+       | Remote Creates Bidirectional Stream

s/Remote/peer

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2087#pullrequestreview-180583527