Re: [quicwg/base-drafts] sender SHOULD limit bursts (#3936)

ianswett <notifications@github.com> Mon, 27 July 2020 19:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D1DD23A0B34 for <quic-issues@ietfa.amsl.com>; Mon, 27 Jul 2020 12:25:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qN2XZAdEe38Q for <quic-issues@ietfa.amsl.com>; Mon, 27 Jul 2020 12:25:38 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D40B63A0B33 for <quic-issues@ietf.org>; Mon, 27 Jul 2020 12:25:37 -0700 (PDT)
Received: from github-lowworker-d93c4b6.va3-iad.github.net (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47]) by smtp.github.com (Postfix) with ESMTP id D829E840E78 for <quic-issues@ietf.org>; Mon, 27 Jul 2020 12:25:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595877936; bh=iBaSAJmXJj42RLaT00mXZjaEHZVAUuIcgKjoP9lEsws=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JfRRtHVWDM3GiJ5S6Ng4U3EmQIivuocCjmwsOpphvBBTuFDC60/p1zNldDm/zqCOc iesDmSq7YXRn1UON8U9PdqtITyqq2EaN1A5e5k//fvrIhEIP4JdhYRGH86Go8TOULL J+ozeAczvLQxqeSQ+l1muMYwcQN4dYbAAu2AUP6o=
Date: Mon, 27 Jul 2020 12:25:36 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY3B6WEOUUPGNTF44N5FMFTBEVBNHHCPCSHKI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3936/review/456068608@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3936@github.com>
References: <quicwg/base-drafts/pull/3936@github.com>
Subject: Re: [quicwg/base-drafts] sender SHOULD limit bursts (#3936)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f1f2a30c7e31_689d3f8085ecd96c31384d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pq-q_g0FAesormcZv_LgdyfP67k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jul 2020 19:25:40 -0000

@ianswett approved this pull request.

This LG.  One nit is that I don't think the knowledge needs to be prior, since it could be experimentally determined, particularly with a loss-based CC like Reno which will decrease CWND and rate upon experiencing loss.

> @@ -877,12 +877,15 @@ similar to a sender's response on a Retransmission Timeout (RTO) in TCP
 
 ## Pacing {#pacing}
 
-This document does not specify a pacer, but it is RECOMMENDED that a sender pace
-sending of all in-flight packets based on input from the congestion
-controller.  Sending multiple packets into the network without any delay between
-them creates a packet burst that might cause short-term congestion and losses.
-Implementations MUST either use pacing or another method to limit such bursts
-to the initial congestion window; see {{initial-cwnd}}.
+A sender SHOULD pace sending of all in-flight packets based on input from the
+congestion controller.
+
+Sending multiple packets into the network without any delay between them creates
+a packet burst that might cause short-term congestion and losses. Senders MUST
+either use pacing or limit such bursts. Senders SHOULD limit bursts to the
+initial congestion window; see {{initial-cwnd}}. A sender with prior knowledge

```suggestion
initial congestion window; see {{initial-cwnd}}. A sender with knowledge
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3936#pullrequestreview-456068608