[quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)

Marten Seemann <notifications@github.com> Tue, 05 February 2019 03:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 72D0212F295 for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 19:18:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id 8tbNIjgjvBpo for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 19:17:58 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B0FF31294FA for <quic-issues@ietf.org>; Mon, 4 Feb 2019 19:17:58 -0800 (PST)
Date: Mon, 04 Feb 2019 19:17:57 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549336677; bh=Gvyu2h63xG9Je2cO1Z+GkkSrdxwXP+uERg37WwRIbVQ=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=UmbMm46zsxBE7+JLUL4eTVWIS8GosCYpEhynmLDfMYdrK8Q1XrNlNGHKQJ8r7bBu8 vnmKTY9LMNSCo3zx9KWjKd58twTZwHuBlILVMQhXRthSdvh3jjryO4wbuggRzK/gbA wQtQZNTl8i+T4CAwOyBx/JqxzyADFWetOGyRpaKo=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab29d13520d6fb85086ed02c416344cf2bc639e2a292cf000000011870c26592a169ce183c6fbc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2417@github.com>
Subject: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5900653e6ef_68743fccc20d45c01946fb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pqAOCI3VUhIAUM0Ed9Pj8_s2ESA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Feb 2019 03:18:00 -0000

This is an ongoing attempt to resolve #2405.
In the current state this PR is nowhere near complete, but I hope it gets the discussion going about the necessary changes. I will update it accordingly.

So far, this PR makes the following changes:

- makes it explicit that the variables `largest_sent_packet`, `largest_acked_packet` and `sent_packets` are kept for every packet number space. By indexing these variables with their respective packet number space, we can immediately see where we need to pass a packet number space variable around,
- makes it explicit that `OnPacketAcked` and `DetectLostPackets` are packet-number-space dependent,
- I realized that `loss_time` would also apply to every packet number space, if we didn't have special treatment for crypto packets. Since we have that, we never run early retransmit for crypto packets, so `loss_time` only applies to the 1-RTT packet number space.
  - I'm not sure if is this a bug or a feature. The only way to declare crypto packets lost now is using the crypto timer. Contrary to what we say in the text, this is *less* aggressive than the logic we use for packets sent after completion of the handshake.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * update the pseudo code to include packet number spaces

-- File Changes --

    M draft-ietf-quic-recovery.md (79)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: