IETF Logo Mail Archive

Re: [quicwg/base-drafts] Initial secrets change after Retry (#2870)

Mike Bishop <notifications@github.com> Wed, 07 August 2019 19:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 25087120694 for <quic-issues@ietfa.amsl.com>; Wed, 7 Aug 2019 12:35:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WCzwvrKdjbWY for <quic-issues@ietfa.amsl.com>; Wed, 7 Aug 2019 12:34:59 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DA8FF120693 for <quic-issues@ietf.org>; Wed, 7 Aug 2019 12:34:58 -0700 (PDT)
Date: Wed, 07 Aug 2019 12:34:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1565206497; bh=WgkHJMgKfmYHtWzXD3R7t1aXohSCrOLp7sovhFASsWQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NWcxJ+SRegAGxGwBqO3mkN6/BqRZbjng1YGVe/IGsDTz0SU2gXlwlKyriwdzk4VZP UtxTfNg3GwwAuXkh3Y3FJWg935Bc2Oh/gQOH96k1ttAAzl5pqI5PyDtF1BkALf4WJS Q4NwWQl8cOFbdMFULOGM/g6/PQiFqDuT2nOnOXB8=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6AULXAGFWDD4QFGQN3LBNGDEVBNHHBXIMFLY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2870/review/272183077@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2870@github.com>
References: <quicwg/base-drafts/pull/2870@github.com>
Subject: Re: [quicwg/base-drafts] Initial secrets change after Retry (#2870)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d4b27e1d487c_60f93fe5382cd960428235"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pzNxA-LpA8l2h5Cf-ojwkx23fsI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Aug 2019 19:35:00 -0000

MikeBishop approved this pull request.

This is fine for clarifying the current state of affairs.  I think we need to come to a conclusion on #2823, however, whether that will stay the case.

> @@ -800,8 +799,10 @@ modifying the contents of packets from future versions.
 The HKDF-Expand-Label function defined in TLS 1.3 MUST be used for Initial
 packets even where the TLS versions offered do not include TLS 1.3.
 
-{{test-vectors-initial}} contains test vectors for the initial packet
-encryption.
+The secrets used for protecting Initial packets changes when a server sends a

```suggestion
The secrets used for protecting Initial packets change when a server sends a
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2870#pullrequestreview-272183077

v2.23.0 | Report a Bug | By Email