Re: [quicwg/base-drafts] Migration in Security Considerations (#2427)
Martin Thomson <notifications@github.com> Wed, 06 February 2019 01:00 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EA365128BCC for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 17:00:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ehUW6P0naMID for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 17:00:51 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B02A7128B01 for <quic-issues@ietf.org>; Tue, 5 Feb 2019 17:00:51 -0800 (PST)
Date: Tue, 05 Feb 2019 17:00:50 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549414850; bh=05AoPWVvhTx/ISU+tnu3WZleJf3ikSeIPGOlOdeCLqA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZTUpUmXSOXsD8Yx344Lhlbe8YfXkFXWzngRtuuUhDYikJTtQOpyowtAqSRGio4z3W advgrQqd2svzR06Q6x8CmA+5smws9Jkm+YhXbHLpfs6fEBT4nsUmjkOxrSLi8B1CiX 51dUZRgLs+SXMERhX/PfFnwUmyc1fOhuLG77Oct8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7442959a71936c4b679f2c17f2301af4573a330792cf000000011871f3c292a169ce1842e6ac@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2427/review/200376535@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2427@github.com>
References: <quicwg/base-drafts/pull/2427@github.com>
Subject: Re: [quicwg/base-drafts] Migration in Security Considerations (#2427)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5a31c28f499_76583fdf5f0d45c03459a1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/q-fjkiDP0NRG73hlQN2shfznoIM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 01:00:54 -0000
martinthomson commented on this pull request. Seems mostly right. Though I would prefer something that simply highlighted the fact that a remote address is not expected to be stable over the lifetime of a connection. Therefore, decisions that use an address as input need to either keep up to date, or accept the consequences of not doing so. I would also point out that this is true even if migration is disabled. > @@ -1463,6 +1463,13 @@ could pose a security risk to an incautious implementer. An implementation MUST ensure that the length of a frame exactly matches the length of the fields it contains. +Certain HTTP implementations use the client address for logging or +access-control purposes. Since QUIC supports path migration (and future +versions might support simultaneous use of multiple paths), such implementations +will need to actively retrieve the client's current address or addresses when ... will need to either actively retrieve the current address, or explicitly accept that the original address might change. I don't think that they have to do either as long as the original requirement is recognized. Of course, I would prefer to say that address-based access control is silly, but it is unfortunately still widely used, and not just for DoS mitigation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2427#pullrequestreview-200376535
- [quicwg/base-drafts] Migration in Security Consid… Mike Bishop
- Re: [quicwg/base-drafts] Migration in Security Co… Martin Thomson
- Re: [quicwg/base-drafts] Migration in Security Co… Kazuho Oku
- Re: [quicwg/base-drafts] Migration in Security Co… ianswett
- Re: [quicwg/base-drafts] Migration in Security Co… Mike Bishop
- Re: [quicwg/base-drafts] Migration in Security Co… Mike Bishop
- Re: [quicwg/base-drafts] Migration in Security Co… Mike Bishop