[quicwg/base-drafts] OnPacketAcknowledgment pseudocode is unclear (#3236)

martinduke <notifications@github.com> Sat, 16 November 2019 03:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D0F91200B1 for <quic-issues@ietfa.amsl.com>; Fri, 15 Nov 2019 19:36:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Px5FQgU2Bhej for <quic-issues@ietfa.amsl.com>; Fri, 15 Nov 2019 19:36:19 -0800 (PST)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F08E61200A4 for <quic-issues@ietf.org>; Fri, 15 Nov 2019 19:36:18 -0800 (PST)
Received: from github-lowworker-39ac79b.ac4-iad.github.net (github-lowworker-39ac79b.ac4-iad.github.net [10.52.18.15]) by smtp.github.com (Postfix) with ESMTP id 2CBAE6E0541 for <quic-issues@ietf.org>; Fri, 15 Nov 2019 19:36:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573875378; bh=UhSgAAJy5m2l74h4j7YpaCiOKf42XYBCEt34vzf45dk=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=nyvAiVxJTP3qo9/m/yamdm87aXrxkc+SP2h+S+766CYGnsMTnXswBcDnAfFU9tDj2 6vQzgAZhETkJkZyDE3fEF7R2HY1DmEJihNcAKm7f8Su/OgKELFYYxZnbx0AbRXLN8C Q+gQOTQz2c0/1H94kxa6UoWkblRy0pmaLmEnren8=
Date: Fri, 15 Nov 2019 19:36:18 -0800
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY4A2AXR4FFYDJA4HV33SQTFEVBNHHB6OCO7E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3236@github.com>
Subject: [quicwg/base-drafts] OnPacketAcknowledgment pseudocode is unclear (#3236)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dcf6eb21d6a0_df63fbd33acd96c10773b0"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/q5UBXS0WoXEFp-PsMAuFLvy05fc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Nov 2019 03:36:21 -0000

the pseudocode refers to IsAppLImited(). This function is not defined anywhere, and as Section 6.9 makes clear, it's not just app limited, but also if it's flow-control limited. It would be good to rename this function.

I've already had an engineer screw this up by following just the psuedocode.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3236