IETF Logo Mail Archive

[quicwg/base-drafts] Replace HTTP_MALFORMED_FRAME error code (#2662)

Lucas Pardue <notifications@github.com> Wed, 01 May 2019 10:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5FB631200E0 for <quic-issues@ietfa.amsl.com>; Wed, 1 May 2019 03:16:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ux03KR5iJ_gh for <quic-issues@ietfa.amsl.com>; Wed, 1 May 2019 03:16:03 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90FC61200B9 for <quic-issues@ietf.org>; Wed, 1 May 2019 03:16:03 -0700 (PDT)
Date: Wed, 01 May 2019 03:16:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1556705762; bh=68hvBO1t7+jNk5b1KZzEOnfzdo1QHrpS0CImIKdKcAE=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=B3RtuXIntgMlpKX1/13hJdCclv3WHxAv40tTBtiV7GglgvzjjYEQQoZ6MCBwyekVD BkvTaneZO3ZKolw/RME7et7Lwe/tevDYtyssETNeAFCLwcllLkc7ua8KGWPzPVJ+Aj 7W8mZwI1jiI0WKEaX8nu1FLmDAMf/BtSgSaQAqNA=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK75BA2RFQDZYZP6O2V222SGFEVBNHHBULDWIQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2662@github.com>
Subject: [quicwg/base-drafts] Replace HTTP_MALFORMED_FRAME error code (#2662)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cc971e29b98a_c443fc2f20cd95c5029f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qFfHW6MDonP-4fa0cTocfHSasqo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 May 2019 10:16:05 -0000

This fixes #2551.

Several changes here that all go toward replacing the generic HTTP_MALFORMED_FRAME error. It adds 4 new error codes that cover specific error cases already highlighted. Chiefly, it restores the HTTP_FRAME_SIZE_ERROR capability we dropped from HTTP/2, just under a different name.

This PR may trigger the Yet-another-error-code early warning system. However, in practical terms this change reduces the error code space by ~250, based on the fact that en endpoint would do frame length validation of unknown frame types and send an error in such a case.  It also avoids the future complexity required to signal errors on extension frames types above the limit aka the `0xff` problem punt.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/2662

-- Commit Summary --

  * replace HTTP_MALFORMED_FRAME error code.

-- File Changes --

    M draft-ietf-quic-http.md (64)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/2662.patch
https://github.com/quicwg/base-drafts/pull/2662.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2662

v2.23.0 | Report a Bug | By Email