Date: Wed, 08 Apr 2020 17:44:25 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK7IGQOR3LWSXUENVHV4TJIOTEVBNHHCHAGI2A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3565/review/390422632@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3565@github.com>
References: <quicwg/base-drafts/pull/3565@github.com>
Subject: Re: [quicwg/base-drafts] Forbid zero-length connection ID with
 preferred addresses (#3565)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e8e6fe94e13a_1af23ff46c6cd9646475";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qHzhP3X26plSa44Lx-XXFJkqO68>


----==_mimepart_5e8e6fe94e13a_1af23ff46c6cd9646475
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@martinthomson commented on this pull request.



> @@ -4740,6 +4740,14 @@ preferred_address (0x0d):
   be at least one unused active connection ID when the client initiates
   migration to the preferred address.
 
+: The Connection ID and Stateless Reset Token fields of a preferred address are
+  identical in syntax and semantics to the corresponding fields of a
+  NEW_CONNECTION_ID frame ({{frame-new-connection-id}}).  A server that chooses
+  a zero-length connection ID MUST NOT provide a preferred address.  Similarly,

Thanks for taking this to the issue.

NEW_CONNECTION_ID can't [change to or from zero-length](https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#section-19.15-6), so this is making this feature consistent with that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3565#discussion_r405894081
----==_mimepart_5e8e6fe94e13a_1af23ff46c6cd9646475
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@martinthomson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3565#discussion_r405894081">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -4740,6 +4740,14 @@ preferred_address (0x0d):
   be at least one unused active connection ID when the client initiates
   migration to the preferred address.
 
+: The Connection ID and Stateless Reset Token fields of a preferred address are
+  identical in syntax and semantics to the corresponding fields of a
+  NEW_CONNECTION_ID frame ({{frame-new-connection-id}}).  A server that chooses
+  a zero-length connection ID MUST NOT provide a preferred address.  Similarly,
</pre>
<p>Thanks for taking this to the issue.</p>
<p>NEW_CONNECTION_ID can't <a href="https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#section-19.15-6" rel="nofollow">change to or from zero-length</a>, so this is making this feature consistent with that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3565#discussion_r405894081">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK2JQFDDE4PUWYFOJS3RLUK6TANCNFSM4MC3YE4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK2XTCXT35MI4HSUVHLRLUK6TA5CNFSM4MC3YE4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC5CWA2A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3565#discussion_r405894081",
"url": "https://github.com/quicwg/base-drafts/pull/3565#discussion_r405894081",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e8e6fe94e13a_1af23ff46c6cd9646475--