Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)

Kazuho Oku <notifications@github.com> Tue, 16 April 2019 00:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 56FB812028B for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 17:17:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T184dkO762Mi for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 17:17:29 -0700 (PDT)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A7F91120043 for <quic-issues@ietf.org>; Mon, 15 Apr 2019 17:17:29 -0700 (PDT)
Date: Mon, 15 Apr 2019 17:17:29 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555373849; bh=P3owZWAX7KoSLzBGbVgRX3TVoqSPinmJF35opHm0TD8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=EaXQgS2+Ffz4bgSZytEwFkV2/1ttK1q7RySFMwCeXP+i4gg+sXinSvbazSsiyyCSS en1XHrDwKe74gy0DmuKA3cjW20PX05a4X9WX3Ud0fD4NDiMroUhlzDtGAUSDAdcZoQ d/hauEh1/1F/7IhEiO0FOsGBkwOYIP3tPQ47WmbE=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe2a2532164ea59af02518bd91957fdc6a4f4c14092cebac2519992a169ce19d467b3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2621/c483464639@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2621@github.com>
References: <quicwg/base-drafts/pull/2621@github.com>
Subject: Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb51f198955_27a53f86eb0d45c41051ad"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qLu9CLmzl4_nqZ0CXRUBe0-CAbA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 00:17:31 -0000

> Good point about 62 bits, but I'm generally wary of implementing PN as a signed int. You'd have to check for < 0 in all sorts of places then.

Yeah, we do not need to check < 0 for things we receive, because the encodings don't allow you to transfer negative numbers. So I think use of -1 does not introduce complexity.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2621#issuecomment-483464639