Re: [quicwg/base-drafts] Prohibit IP fragmentation (#3280)

Gorry Fairhurst <notifications@github.com> Tue, 03 December 2019 07:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D91AA120123 for <quic-issues@ietfa.amsl.com>; Mon, 2 Dec 2019 23:39:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VwmfYm2jZOIT for <quic-issues@ietfa.amsl.com>; Mon, 2 Dec 2019 23:39:41 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7AD25120104 for <quic-issues@ietf.org>; Mon, 2 Dec 2019 23:39:41 -0800 (PST)
Received: from github-lowworker-d31a065.va3-iad.github.net (github-lowworker-d31a065.va3-iad.github.net [10.48.17.70]) by smtp.github.com (Postfix) with ESMTP id 89D556A044A for <quic-issues@ietf.org>; Mon, 2 Dec 2019 23:39:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575358780; bh=PP7jcgXs1suIUsJ8sP5JlC451/BFax5bhJ63+LYJoxw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RRglySt4hc5RXOnIlRgkxCM3FlKs5O4Z1Vq1vpDrQlXCY4uQsTWdC+Fo2AwyIfEiD UT80xtSVmLweluk+cZKhXUSnIJrOs9pvrjSD0NqewsrRuMnBOMA60e5sPBwQje3a8G o59p6ynsS+V2sTj5QjSB6jDGBq5v787ZREAsQxnE=
Date: Mon, 02 Dec 2019 23:39:40 -0800
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK34JVV5HE7H6JOK6J536NB3ZEVBNHHB7MJOHY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3280/review/325940708@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3280@github.com>
References: <quicwg/base-drafts/pull/3280@github.com>
Subject: Re: [quicwg/base-drafts] Prohibit IP fragmentation (#3280)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5de6113c7a8ff_7e653fc7198cd96020958e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qMDj2JlRIfngJMk1l86EqI_MRK8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Dec 2019 07:39:43 -0000

gorryfair commented on this pull request.



> @@ -3471,6 +3471,10 @@ Datagrams containing Initial packets MAY exceed 1200 bytes if the client
 believes that the Path Maximum Transmission Unit (PMTU) supports the size that
 it chooses.
 
+UDP datagrams MUST NOT be fragmented at the IP layer.  In IPv4
+{{!IPv4=RFC0791}}, the DF bit MUST be set to prevent fragmentation on the path.
+Endpoints SHOULD discard fragmented IP packets.

I believe this is desirable at the receiving endpoint, but saying  "Endpoints SHOULD discard fragmented IP packets." ... isn't something that the transport has control over. I suggest you remove this. It seems sufficient to say at the sender don't do IPv4 or IPv6 fragmentation and do set FD

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3280#pullrequestreview-325940708