Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to request streams (#2323)
Kazuho Oku <notifications@github.com> Thu, 10 January 2019 05:19 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B4A6C131158 for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 21:19:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rx7QnBwcGx6x for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 21:19:19 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0A057131155 for <quic-issues@ietf.org>; Wed, 9 Jan 2019 21:19:19 -0800 (PST)
Date: Wed, 09 Jan 2019 21:19:18 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547097558; bh=j3/x0dABCsgYjzC+0bZN6OrV2zB5+COUefbyZGBI/fA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=aK17BpwMi9Bh8126uAUTO+rOOuS49TXLk95A4v2eXibrraDBEa9uEwJhy2NQlFVTy ED93438HsA4zxNzoMqV652HJjw19KfwaPfsykDH11HrgU+sBY3gm5M4op8x//niZ5y XtnVZH5dKv6JZvNaBTB70XIcCPqiaDAqYwyb1I+4=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab402c23bceecb937398f7aa0d79ad605568d49d4a92cf00000001184e97d692a169ce17b13d9c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2323/review/191052294@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2323@github.com>
References: <quicwg/base-drafts/pull/2323@github.com>
Subject: Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to request streams (#2323)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c36d5d63193c_7d43f9f982d45c047062e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qNBHQurgGbf9qY_J6zs0NpVjZyg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 05:19:21 -0000
kazuho commented on this pull request.
> @@ -723,7 +723,7 @@ with its 0-RTT data.
### PUSH_PROMISE {#frame-push-promise}
The PUSH_PROMISE frame (type=0x05) is used to carry a promised request header
-set from server to client, as in HTTP/2.
+set from server to client on a request stream, as in HTTP/2.
Thank you for the clarification. I think having the restriction is fine, because now I realize that RFC 7540 has the same restriction.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2323#discussion_r246638614
- [quicwg/base-drafts] Restrict PUSH_PROMISE to req… Mike Bishop
- Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to… Mike Bishop
- Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to… Kazuho Oku
- Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to… Kazuho Oku
- Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to… Mike Bishop
- Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to… Mike Bishop