Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)
Kazuho Oku <notifications@github.com> Tue, 18 September 2018 14:36 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8C1A130E42 for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 07:36:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uVNZUvyZ6BlJ for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 07:36:12 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A20B9130E0C for <quic-issues@ietf.org>; Tue, 18 Sep 2018 07:36:11 -0700 (PDT)
Date: Tue, 18 Sep 2018 07:36:10 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537281370; bh=E+ZNtYo/5DgFbdFnW6cRGx3PDCB/syM6EzojKXKEkfo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kohjbdrLL/eAhmktZasgTx+jFCxmH8BwXgd8nN9T7jRTyOOsHqbFufee0WxredB3b 5DczJPxxRKZta7cJImMp4lxT7rSdtw6GciTocIR77dGpxp5FfajADNSstYEGjEd3r5 Szt5CY8GkjrI6RLZLpqjYaCM3Vei37abNPdw+4n0=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2aef578a9b5d15b495215d690970e8951eff2b3592cf0000000117b8cf5a92a169ce1586350b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1763/c422418166@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1763@github.com>
References: <quicwg/base-drafts/pull/1763@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba10d5a16b49_7df93fbe76ad45c027924f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qOAdJvYQExsHezF-NfdCifICJYg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 14:36:14 -0000
@dtikhonov > You don't need an array that large, as you can only have 4096 / 32 = 128 entries. One can do with 128-element ring buffer. Implementation-wise that's correct. OTOH, let me note that the table size needs to be 4096 / 16 = 256 entries spec-wise so that we do not have ambiguity in if the Largest Reference refers to an entry yet to be delivered. @afrind > Since one cannot really have a table full of 0 byte entries, you practically don't need even a MaxEntries/32 size ring buffer. It's a nice memory optimization to allocate say only half that many entries, and resize it when needed. That is true. The overhead is 25% compared to the size of the header table on 64-bit architectures assuming that the ring buffer is implemented as an array of pointers. I am not sure if that is a deal blocker, but it is certainly an overhead. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1763#issuecomment-422418166
- [quicwg/base-drafts] QPACK: Encode Largest Refere… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… MikkelFJ
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Kazuho Oku
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Kazuho Oku
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Kazuho Oku
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… MikkelFJ
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… MikkelFJ
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… MikkelFJ
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Kazuho Oku
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Mike Bishop
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Mike Bishop
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Bence Béky
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Bence Béky
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Bence Béky