Re: [quicwg/base-drafts] Conflicting error codes (#4087)
Christian Huitema <notifications@github.com> Mon, 14 September 2020 15:27 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5EA483A0B9C for <quic-issues@ietfa.amsl.com>; Mon, 14 Sep 2020 08:27:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.917
X-Spam-Level:
X-Spam-Status: No, score=-2.917 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.695, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, HTML_OBFUSCATE_05_10=0.26, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1wsFQHgVuW2Z for <quic-issues@ietfa.amsl.com>; Mon, 14 Sep 2020 08:27:34 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 299353A0B98 for <quic-issues@ietf.org>; Mon, 14 Sep 2020 08:27:34 -0700 (PDT)
Received: from github-lowworker-943b171.ac4-iad.github.net (github-lowworker-943b171.ac4-iad.github.net [10.52.22.59]) by smtp.github.com (Postfix) with ESMTP id 16ADE52149F for <quic-issues@ietf.org>; Mon, 14 Sep 2020 08:27:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1600097253; bh=8r6Y2Lhn3SQXg7pVIfwaMlXUXGLkpHfXtVMqwzPMwXs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KslH82joyVlTmFzsGwcWZA6uizYaK751sBMGTQci0qbKhUCMf+qRX9MGX8XcHFA7T o9K9jAaBPJEd4VLfCj/HXeRVZsbTBal+hijof6Nq7eRRg2agNIa9U89g1/6tLqWqJN Bvmz6+ZM+f0hWekRGNNRM78Jq0N4qaokHXCNp1ak=
Date: Mon, 14 Sep 2020 08:27:33 -0700
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZGJ4BPABOHPN56NDV5NNWOLEVBNHHCTETOJE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4087/692132583@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4087@github.com>
References: <quicwg/base-drafts/issues/4087@github.com>
Subject: Re: [quicwg/base-drafts] Conflicting error codes (#4087)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f5f8be567d2_74519f0363023"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qXoHjhD-L7__7h86yqrBcEyJVh0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Sep 2020 15:27:35 -0000
I am trying to write a test for the generation of the key update error code. This is a bit hard, since by default the implementation will rotate keys after sending more than <close-to-the-limit> packets, and thus the condition is not seen. One could test that the peer has sent more than <limit> packets without rotating the keys, but then there is some fuzziness to what the limit is. For example, for AES GCM, should that be "received 2**25 packets" or "2**25 + 1"? The error is also a bit silly. It requires tracking how many packets were decrypted with a given key, and then disconnecting with a specific error if the limit is exceeded. But the node that tracks the limit could also unilaterally trigger a key rotation if the receive count is getting close enough. Of course, the non-standard peer could refuse to update its own key, and never rotate the key phase. Is *that* the condition for KEY_UPDATE_ERROR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/4087#issuecomment-692132583
- [quicwg/base-drafts] Conflicting error codes (#40… Tatsuhiro Tsujikawa
- Re: [quicwg/base-drafts] Conflicting error codes … Marten Seemann
- Re: [quicwg/base-drafts] Conflicting error codes … Martin Thomson
- Re: [quicwg/base-drafts] Conflicting error codes … David Schinazi
- Re: [quicwg/base-drafts] Conflicting error codes … ekr
- Re: [quicwg/base-drafts] Conflicting error codes … Jana Iyengar
- Re: [quicwg/base-drafts] Conflicting error codes … Christian Huitema
- Re: [quicwg/base-drafts] Conflicting error codes … Jana Iyengar
- Re: [quicwg/base-drafts] Conflicting error codes … Christian Huitema
- Re: [quicwg/base-drafts] Conflicting error codes … Jana Iyengar
- Re: [quicwg/base-drafts] Conflicting error codes … Christian Huitema
- Re: [quicwg/base-drafts] Conflicting error codes … Marten Seemann
- Re: [quicwg/base-drafts] Conflicting error codes … Martin Thomson
- Re: [quicwg/base-drafts] Conflicting error codes … Marten Seemann
- Re: [quicwg/base-drafts] Conflicting error codes … Christian Huitema
- Re: [quicwg/base-drafts] Conflicting error codes … Marten Seemann
- Re: [quicwg/base-drafts] Conflicting error codes … David Schinazi
- Re: [quicwg/base-drafts] Conflicting error codes … Martin Thomson