IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't retransmit lost packets that are acked later (#3957)

Jana Iyengar <notifications@github.com> Tue, 28 July 2020 01:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F6C13A09D5 for <quic-issues@ietfa.amsl.com>; Mon, 27 Jul 2020 18:25:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TXX7BD9M6hGz for <quic-issues@ietfa.amsl.com>; Mon, 27 Jul 2020 18:25:09 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B8D653A09B1 for <quic-issues@ietf.org>; Mon, 27 Jul 2020 18:25:09 -0700 (PDT)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id E7109520BFB for <quic-issues@ietf.org>; Mon, 27 Jul 2020 18:25:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595899508; bh=6zJxI7bC51ZdAO7SXVcyH8dke5dlC8BU4xRaFmfErxY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Em7EeymXg+j0y2kCT0YEEDxDGCzKdH/vLDhX9WxyPHKMamjuW0S4Wmtb6Ksa/nYxP JQlLKJWS8BtWknVND6JEvPpoECODyIZzSkGK/0zpkmEgpyXbPq4RWy3M2fZtVNRldu /5jeVnss/1f/V790vMXTRqWiv7I8Kf3VZwGabm5w=
Date: Mon, 27 Jul 2020 18:25:08 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7ABEJETDHMBR7FQBF5FNPXJEVBNHHCPIKQDU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3957/review/456240160@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3957@github.com>
References: <quicwg/base-drafts/pull/3957@github.com>
Subject: Re: [quicwg/base-drafts] Don't retransmit lost packets that are acked later (#3957)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f1f7e74d5fc9_5d673fec9c4cd95c11219d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/q_c-PPlaudPsJYXUeL631wjUBQU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2020 01:25:12 -0000

@janaiyengar commented on this pull request.



> +acknowledged. This includes packets that are acknowledged after being declared
+lost. Doing so requires senders to retain information about packets after they
+are declared lost. A sender can discard this information after a period of time
+elapses, such as a PTO (Section 6.2 of {{QUIC-RECOVERY}}), or on other events,
+such as reaching a memory limit.

I will take the compression, but we don't need to say "expected maximum packet reordering", since that's not a well-defined term. I'll spell in out in other words.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3957#discussion_r461262443

v2.30.2 | Report a Bug | By Email | System Status