IETF Logo Mail Archive

Re: [quicwg/base-drafts] Application can reset stream or close connection even if no error occurs. (#3953)

Bence Béky <notifications@github.com> Fri, 24 July 2020 11:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D13E3A0EFC for <quic-issues@ietfa.amsl.com>; Fri, 24 Jul 2020 04:37:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.554
X-Spam-Level:
X-Spam-Status: No, score=-1.554 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fDzIEISzRvRb for <quic-issues@ietfa.amsl.com>; Fri, 24 Jul 2020 04:37:07 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5DE633A0EFB for <quic-issues@ietf.org>; Fri, 24 Jul 2020 04:37:07 -0700 (PDT)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 0454B600E3D for <quic-issues@ietf.org>; Fri, 24 Jul 2020 04:37:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595590626; bh=aXm2aooXHG59PYHI5RCxS+Pfh+1B10xr/L4H6T3J6u0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=h3TrwcthASgDP0K14qKxyJbuxcuKHaK6M6yC93m33ci14Lkm6e9HCEJqRSR6uMIPd 2FPJ8kim0PFQcQOvjz24ZVGpdEsgQqeowzdhDZLbXd7q3+SN+SGFZExcCSQzazDpIJ hU5MJ4up4LRcNGfs5cxi5uOUUN0WDGUnDXHnyQLs=
Date: Fri, 24 Jul 2020 04:37:05 -0700
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3A43QJ7VZ6YTKNOHV5E2UODEVBNHHCPHAWOE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3953/review/454818047@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3953@github.com>
References: <quicwg/base-drafts/pull/3953@github.com>
Subject: Re: [quicwg/base-drafts] Application can reset stream or close connection even if no error occurs. (#3953)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f1ac7e1e8c88_55863fcfde6cd96c138940"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qkfyC-IGFlam0YIZC7PSbd-hPLk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jul 2020 11:37:09 -0000

@bencebeky commented on this pull request.



> +the entire connection; see Sections 2.4 and 5.3 of {{QUIC-TRANSPORT}}.  This
+is referred to as a "stream error" or "connection error" (see
+Section 11 of {{QUIC-TRANSPORT}}) and has an associated error code, but does not
+necessarily have to be an error.  For example, a stream can be reset if the
+requested resource is no longer needed.

I'm accepting your suggestion but also pluralizing "stream error" and "connection error" (which incidentally were already plural before this PR).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3953#discussion_r460000264

v2.46.0 | Report a Bug | By Email | System Status