Date: Fri, 24 Jul 2020 04:37:05 -0700
From: =?UTF-8?B?QmVuY2UgQsOpa3k=?= <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK3A43QJ7VZ6YTKNOHV5E2UODEVBNHHCPHAWOE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3953/review/454818047@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3953@github.com>
References: <quicwg/base-drafts/pull/3953@github.com>
Subject: Re: [quicwg/base-drafts] Application can reset stream or close
 connection even if no error occurs. (#3953)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5f1ac7e1e8c88_55863fcfde6cd96c138940";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qkfyC-IGFlam0YIZC7PSbd-hPLk>


----==_mimepart_5f1ac7e1e8c88_55863fcfde6cd96c138940
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@bencebeky commented on this pull request.



> +the entire connection; see Sections 2.4 and 5.3 of {{QUIC-TRANSPORT}}.  This
+is referred to as a "stream error" or "connection error" (see
+Section 11 of {{QUIC-TRANSPORT}}) and has an associated error code, but does not
+necessarily have to be an error.  For example, a stream can be reset if the
+requested resource is no longer needed.

I'm accepting your suggestion but also pluralizing "stream error" and "connection error" (which incidentally were already plural before this PR).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3953#discussion_r460000264
----==_mimepart_5f1ac7e1e8c88_55863fcfde6cd96c138940
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@bencebeky</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3953#discussion_r460000264">draft-ietf-quic-http.md</a>:</p>
<pre style='color:#555'>&gt; +the entire connection; see Sections 2.4 and 5.3 of {{QUIC-TRANSPORT}}.  This
+is referred to as a &quot;stream error&quot; or &quot;connection error&quot; (see
+Section 11 of {{QUIC-TRANSPORT}}) and has an associated error code, but does not
+necessarily have to be an error.  For example, a stream can be reset if the
+requested resource is no longer needed.
</pre>
<p>I'm accepting your suggestion but also pluralizing "stream error" and "connection error" (which incidentally were already plural before this PR).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3953#discussion_r460000264">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJKYSWOHHAJ3JTCHCJG3R5FW6DANCNFSM4PFZT42Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK6CNBKN6XFZ6ZEYP23R5FW6DA5CNFSM4PFZT422YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODMN7R7Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3953#discussion_r460000264",
"url": "https://github.com/quicwg/base-drafts/pull/3953#discussion_r460000264",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5f1ac7e1e8c88_55863fcfde6cd96c138940--