Re: [quicwg/base-drafts] Address validation for connection migration (#732)

Martin Thomson <notifications@github.com> Tue, 17 October 2017 03:20 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7E60D1331F5 for <quic-issues@ietfa.amsl.com>; Mon, 16 Oct 2017 20:20:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.019
X-Spam-Level:
X-Spam-Status: No, score=-2.019 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mxA3ausFhlX7 for <quic-issues@ietfa.amsl.com>; Mon, 16 Oct 2017 20:20:16 -0700 (PDT)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C1F42132D41 for <quic-issues@ietf.org>; Mon, 16 Oct 2017 20:20:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=mA+RZL8ZXJ6rp+U0rMb2Mgi+rnQ=; b=EbG1bQzit/jjqc7v 6RIiVknqUl7u2vVZJGnMZr7XtLLdQ+PFDsyTg0tXYWx4/i/lgzRV2TZD1Xc6Y/BE +cxgTGXJxl4MJJLbWg16stjy+7HUzayfl0m8O/k0jgP6aGGEpg3/MpZVp9nhe3uU 1nANIZjbNIix+Iz9DzqmT1ZbSqk=
Received: by filter1111p1mdw1.sendgrid.net with SMTP id filter1111p1mdw1-17237-59E576EF-D 2017-10-17 03:20:15.674789868 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0008p1iad1.sendgrid.net (SG) with ESMTP id A8bw2cB_Thi7Cr2FW0Edgw for <quic-issues@ietf.org>; Tue, 17 Oct 2017 03:20:15.407 +0000 (UTC)
Date: Tue, 17 Oct 2017 03:20:15 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab146563f86a9fdc7ab80d17f3f60eaf2211ae22ad92cf0000000115fd38ef92a169ce0ee9dd49@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/732/review/69756964@github.com>
In-Reply-To: <quicwg/base-drafts/pull/732@github.com>
References: <quicwg/base-drafts/pull/732@github.com>
Subject: Re: [quicwg/base-drafts] Address validation for connection migration (#732)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59e576ef46d63_49e83f817cb56f34701fb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak32z08ZiCOdB6dn3W8IqSl/rcUrYmbJloMJGG FWfafh4Nod8gEUMyjNA1F8ZYRbsPja0Ft+q48G7Qgh4UkL8PvO0W31EXgsrgI8n9eln6vVa7PoeybP fFKeJkV6S9NvPFWCganMBSgFcFnaDzMjvMec4oUJ47+zHnZun4J+o59lACVpRBRsYUU1vp3+i8k2W7 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ql8NoqUanknYPmFL7MownrFQvzM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Oct 2017 03:20:18 -0000

martinthomson commented on this pull request.



> @@ -1351,6 +1355,14 @@ connection when they move networks.  This includes state that can be hard to
 recover such as outstanding requests, which might otherwise be lost with no easy
 way to retry them.
 
+An endpoint that receives packets that contain a source IP address and port that

I agree, we don't know and we should discuss.  But this PR addresses problems with use of new paths that can't otherwise be addressed.  I agree with you that this isn't a great design, it's probably even terrible, but a good design will take time.  You aren't committing to this design though.  I would prefer to see this merged, while recognizing that it is bad in certain specific ways (I don't agree that this is so bad that the protocol will break, however).  I will even open the issue that explains the shortcoming of this design if we merge this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/732#discussion_r145019630