Re: [quicwg/base-drafts] eliminate the difference between when having no RTT sample and having one (#3525)

Kazuho Oku <notifications@github.com> Thu, 19 March 2020 00:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF8523A1EE2 for <quic-issues@ietfa.amsl.com>; Wed, 18 Mar 2020 17:27:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Level:
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JdQ0o4r-7lw5 for <quic-issues@ietfa.amsl.com>; Wed, 18 Mar 2020 17:27:03 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8648B3A1EE1 for <quic-issues@ietf.org>; Wed, 18 Mar 2020 17:27:03 -0700 (PDT)
Received: from github-lowworker-1b8c660.ash1-iad.github.net (github-lowworker-1b8c660.ash1-iad.github.net [10.56.18.59]) by smtp.github.com (Postfix) with ESMTP id 000FB8C116B for <quic-issues@ietf.org>; Wed, 18 Mar 2020 17:27:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584577622; bh=UZ4h4G0U5bgKt0uy64oipXLEVz2ijX4CaVDqVpmrUzg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=c8F0hmpoODt91+REY6/P9us0fHEHQmCXJZ6ivOlzvG1UhvdNe3SrLx6hJS1oUAYRw 6oiD/TZiRXVvsbWh2gpkegMUYFLjDHhAYgQUGTDXCAEbMUUNoemmuhyBNLpywg80O4 0th6x3KD8GSccayctp3CLgWeaLxj2Egk9CDvphLk=
Date: Wed, 18 Mar 2020 17:27:01 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3IJRYSNFUDKPWB7U54P2OVLEVBNHHCFKOIVY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3525/review/377335798@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3525@github.com>
References: <quicwg/base-drafts/pull/3525@github.com>
Subject: Re: [quicwg/base-drafts] eliminate the difference between when having no RTT sample and having one (#3525)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e72bc55e41b9_42f43fe2c8acd95c105130"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qmuW8zDlyDVtYlrO3_dp71FqS1Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Mar 2020 00:27:05 -0000

kazuho commented on this pull request.



> +smoothed_rtt and rttvar are computed as follows, similar to {{?RFC6298}}.  When
+there are no samples for a network path:

Splitting the text when having no samples and having one is intentional, see the changes suggested in https://github.com/quicwg/base-drafts/pull/3525#pullrequestreview-374825664.

I'm personally fine with the changes proposed here, but I would like to see what @ianswett thinks. Maybe it's OK, as the we have two paragraphs right after, discussing about each of the two conditions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3525#discussion_r394720545