IETF Logo Mail Archive

Re: [quicwg/base-drafts] don't allow 0 as a packet number (#832)

Marten Seemann <notifications@github.com> Wed, 04 October 2017 14:00 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21382126B6E for <quic-issues@ietfa.amsl.com>; Wed, 4 Oct 2017 07:00:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.401
X-Spam-Level:
X-Spam-Status: No, score=-0.401 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NYNrTylBgYlw for <quic-issues@ietfa.amsl.com>; Wed, 4 Oct 2017 07:00:14 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 01F811321BB for <quic-issues@ietf.org>; Wed, 4 Oct 2017 07:00:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=LJiWVWyZgssq0hJnf5AIgO447Eg=; b=m7GYvFNh1WKr+/OR x1/HK7VjTAdv482pl3EondsFrwT4zt7VMShxHGHikLj7YVAKAX/lcvm2RUgPp9So +WlB7ES/526RYSBSblODqC0LKxN8ePrK1QuZAj6PDonlAmApIAGRKV7SJi4ZmLlk fvYk5/zLKO+9sjqIEeklcluU8pQ=
Received: by filter0540p1mdw1.sendgrid.net with SMTP id filter0540p1mdw1-20323-59D4E965-4 2017-10-04 14:00:05.057799437 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0008p1iad1.sendgrid.net (SG) with ESMTP id eOATBH9aRvWoBpDrp3u6cg for <quic-issues@ietf.org>; Wed, 04 Oct 2017 14:00:05.013 +0000 (UTC)
Date: Wed, 04 Oct 2017 14:00:05 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab05a2bab85f33960451da6705b9141bd1ce08dcbf92cf0000000115ecab6492a169ce0fa74d75@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/832/334164612@github.com>
In-Reply-To: <quicwg/base-drafts/issues/832@github.com>
References: <quicwg/base-drafts/issues/832@github.com>
Subject: Re: [quicwg/base-drafts] don't allow 0 as a packet number (#832)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59d4e964d8805_55b73fa3af694f281048a2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0v2Yoar9JZzvrBMJn9hPFLICK0E8bFbwM5gK yUCO1s174M1jZk+4cWN2AToEndwTNQWwsMkkfn2FPr5hRcjtkuIR31RESVGidAaUayla9xmSPgI1m2 Q5B6Iu/dKL2QZuZygSjyIbLB/DzNRgjbS6NPfOKtg23kXyWgIpum6FPwe+KTTPZ8gKQMtToKDrHpJd 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qnzuDwj8RH50Drr0Uchy_copPIc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Oct 2017 14:00:15 -0000

Correct, the alternative would be creating bools to track if the first packet was already received, just to cover an extremely improbable corner case in the packet number randomisation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/832#issuecomment-334164612

v2.46.0 | Report a Bug | By Email | System Status