[quicwg/base-drafts] Omission of DCIL change in draft-ietf-quic-transport-22? (#2932)

evagld <notifications@github.com> Tue, 30 July 2019 09:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DDBAD120188 for <quic-issues@ietfa.amsl.com>; Tue, 30 Jul 2019 02:36:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QG_Q-KZiJk_l for <quic-issues@ietfa.amsl.com>; Tue, 30 Jul 2019 02:36:09 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF4451200CD for <quic-issues@ietf.org>; Tue, 30 Jul 2019 02:36:08 -0700 (PDT)
Date: Tue, 30 Jul 2019 02:36:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1564479367; bh=QxLlfUvBIO3AimdsptsmchrggO4/pISez0saPRkCVvo=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=i3+hf8qz/ZZjKUd/wjVIe4EbJkfIktyNlPbLOlaJt8tBE234LmIUCl4fjI7+2XKW0 uYBtClaWWK9pkX1FdiHW3nZgYThI7De3Rvca5TvTSQsuvCIJjzokR4MnWolLWcXl6X GUmsEhTihkJI9YjVyPCMNc72L9RmZXmwZZLp3qBk=
From: evagld <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4JYGH5VDOD4E527V53JVBAPEVBNHHBYR7YKQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2932@github.com>
Subject: [quicwg/base-drafts] Omission of DCIL change in draft-ietf-quic-transport-22? (#2932)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d400f87b60cc_10213f8b462cd95c1107db"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: evagld
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qqikjQ4kcGx5hyMI6m2cfcbzfuU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jul 2019 09:36:11 -0000

I'm currently working on an implementation of the protocol and have juste realized the changes in the last draft of RFC about the DCIL and SCIL. 
Reading the changes, I noticed that the DCID Len didn't change in the draft, opposed to the SCID Len, which doesn't seem rigth :
 "_DCID Len: The byte following the version contains the lengths of the two connection ID fields that follow it. These lengths are encoded as two 4-bit unsigned integers. The Destination
 Connection ID Length (DCIL) field occupies the 4 high bits of the byte and the Source Connection ID Length (SCIL) field occupies the 4 low bits of the byte. An encoded length of 0 indicates that the connection ID is also 0 bytes in length. Non-zero encoded lengths
 are increased by 3 to get the full length of the connection ID, producing a length between 4 and 18 bytes inclusive. For example,  a byte with the value 0x50 describes an 8-byte Destination
 Connection ID and a zero-length Source Connection ID_."
Is it an omission of change or have I missed something?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2932