Re: [quicwg/base-drafts] Remap STOPPING to something other than zero (#1804)

Nick Banks <notifications@github.com> Fri, 28 September 2018 19:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BC62130E7C for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 12:22:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.456
X-Spam-Level:
X-Spam-Status: No, score=-8.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SR6HEJVLJBqa for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 12:22:33 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9FBDA12958B for <quic-issues@ietf.org>; Fri, 28 Sep 2018 12:22:33 -0700 (PDT)
Date: Fri, 28 Sep 2018 12:22:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538162552; bh=DkWlbGGEw+L2DZWyo9K3gQ6gYunV9iVAFlc9NzOoBDI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Il95LWcXjQfWcIJGP5V2SJwDwFKEda7NNKmXjeXcboM0zSQGVfAYlU3cTqbOcnjuj pMqlqR4f/IiMiwR8mrXCX14GE+xn9aV9s7oyZfaKpqJWwCJEioTjxTOUKquxhgVeuH nuBGzEx3byPkLRaPNZhEDViq3f+Uc7y/cZqBanzE=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba06be44033ba02abe1f4a0a87b3ee68c5fe7358492cf0000000117c6417892a169ce15b0cecf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1804/425540297@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1804@github.com>
References: <quicwg/base-drafts/issues/1804@github.com>
Subject: Re: [quicwg/base-drafts] Remap STOPPING to something other than zero (#1804)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bae7f78cc1c5_6da3fb2e22d45b870055"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qrPua4xCr7qhsyyI1ISuz0hcxCw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Sep 2018 19:22:36 -0000

The more I was thinking, if you agree that after you send a STOP_SENDING frame out, you won't indicate anything up to the app layer when you receive any RST_STREAM frame, then the actual error code value doesn't really matter. At most it gets logged locally, and that's it.

We can say that the entire number space is open to the application layer; but we only indicate it up if we haven't sent a STOP_SENDING (i.e. the app layer hasn't closed/shutdown that pipe already).

So, if we haven't sent a STOP_SENDING, then the received RST_STREAM must contain an app error code. If we have sent a STOP_SENDING, then the RST_STREAM might contain either an app error code or a STOPPING value (whatever that is...) but we don't really care, because we will just ignore it.

Then, we can either leave STOPPING as is or just get rid of it entirely and let the implementation send whatever it wants, since we will just ignore it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1804#issuecomment-425540297