Date: Thu, 06 Dec 2018 06:44:29 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab585baf465b6d035fe647145cc0f558d7543e15b192cf000000011820f7cd92a169ce16fa8bda@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2066/review/182271374@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2066@github.com>
References: <quicwg/base-drafts/pull/2066@github.com>
Subject: Re: [quicwg/base-drafts] Refactor DetectLostPackets (#2066)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c0935cd40972_337f3f88514d45b8981f9";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qs_Aoy5x_ZpBsn9L_-j2AffgYJo>


----==_mimepart_5c0935cd40972_337f3f88514d45b8981f9
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett approved this pull request.

This looks good, but I think you should move the where the timers in the past comment lives.

>    if (!lost_packets.empty()):
     OnPacketsLost(lost_packets)
 ~~~
 
+This algorithm results in loss_time being set based on the earliest packet that
+is still in flight.  Timers set based on a loss_time that has already passed

I think this comment about timers with timeouts that have already passed is more widely applicable, so maybe move it closer to SetLossDetectionTimer()?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2066#pullrequestreview-182271374
----==_mimepart_5c0935cd40972_337f3f88514d45b8981f9
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> approved this pull request.</p>

<p>This looks good, but I think you should move the where the timers in the past comment lives.</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2066#discussion_r239478248">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt;    if (!lost_packets.empty()):
     OnPacketsLost(lost_packets)
 ~~~
 
+This algorithm results in loss_time being set based on the earliest packet that
+is still in flight.  Timers set based on a loss_time that has already passed
</pre>
<p>I think this comment about timers with timeouts that have already passed is more widely applicable, so maybe move it closer to SetLossDetectionTimer()?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2066#pullrequestreview-182271374">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq36PK9-4BKfYRSi2a5SUIwQ78IxVks5u2S1NgaJpZM4Y4tgj">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq-LSbu-TkImNEKH3avEj7T5n4vdFks5u2S1NgaJpZM4Y4tgj.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett approved #2066"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2066#pullrequestreview-182271374"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2066#pullrequestreview-182271374",
"url": "https://github.com/quicwg/base-drafts/pull/2066#pullrequestreview-182271374",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ianswett approved 2066",
"sections": [
{
"text": "This looks good, but I think you should move the where the timers in the past comment lives.",
"activityTitle": "**ianswett**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ianswett",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/2066#pullrequestreview-182271374"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 417519651\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5c0935cd40972_337f3f88514d45b8981f9--