Re: [quicwg/base-drafts] Ignore packet loss when the keys are not available (#2327)

Martin Thomson <notifications@github.com> Thu, 10 January 2019 00:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 392EC130DC9 for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 16:41:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ORGtSorNE4Jg for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 16:41:10 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2C42B12DF72 for <quic-issues@ietf.org>; Wed, 9 Jan 2019 16:41:10 -0800 (PST)
Date: Wed, 09 Jan 2019 16:41:09 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547080869; bh=9FbtaTdy6iB64H4yRyBEcufCl8TJE1kmCCjpaXDgmbU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=nLKc8jNq4upXVRptKyArvF1m+gUwUcyBxVgIXY0voZKoK9n3tsASyrdsLnPdjxajr hy6TasoWPl5wow3gREH458bBBIouMF7sZhXQeMRatU6ymy0i3BHF13fV/dZyOJqShM IYmhvst02z0SBiJ3b4aKSZS9AiQdRBlIa42RtL5c=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7665c67ce9e92d694f170b95dce0219eee8157ac92cf00000001184e56a592a169ce17b2473c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2327/review/191007537@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2327@github.com>
References: <quicwg/base-drafts/pull/2327@github.com>
Subject: Re: [quicwg/base-drafts] Ignore packet loss when the keys are not available (#2327)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3694a54593c_53c43fa2be2d45c41296e2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/r2no72ELDMMjqgVuky77y1cwRHk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 00:41:12 -0000

martinthomson approved this pull request.

Some suggestions, but this is good.  Thanks.

> @@ -427,15 +427,33 @@ packet is received.  The client MAY use this value to seed the RTT estimator for
 a subsequent connection attempt to the server.
 
 
-#### Discarding Initial State {#discard-initial}
+#### Discarding Keys and Packet State {#discarding-packets}
+
+When keys are discarded, recovery state for all in-flight packets sent with

I think that we want to use "packet protection keys" on the first mention here.

```suggestion
When packet protection keys are discarded (see Section 4.9 of {{QUIC-TLS}}), recovery state for all in-flight packets sent with
```

>  
+During the handshake, the keys to remove packet protection may not yet be

```suggestion
During the handshake, some packet protection keys might not be
```

>  
+During the handshake, the keys to remove packet protection may not yet be
+available when the packet arrives. In particular, Handshake and 0-RTT packets

```suggestion
available when a packet arrives. In particular, Handshake and 0-RTT packets
```

>  
+During the handshake, the keys to remove packet protection may not yet be
+available when the packet arrives. In particular, Handshake and 0-RTT packets
+will not be processable until the Initial flight arrives and 1-RTT packets

```suggestion
can't be processed until the Initial flight arrives and 1-RTT packets
```

>  
+During the handshake, the keys to remove packet protection may not yet be
+available when the packet arrives. In particular, Handshake and 0-RTT packets
+will not be processable until the Initial flight arrives and 1-RTT packets
+will not be processable until the handshake completes.  Implementations MAY

```suggestion
can't be processed until the handshake completes.  Endpoints MAY
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2327#pullrequestreview-191007537