[quicwg/base-drafts] loss detection timer description could be simplified by definining a timer mode (#3151)

Marten Seemann <notifications@github.com> Fri, 25 October 2019 01:14 UTC

Date: Thu, 24 Oct 2019 18:14:04 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6W4MDIHRMQ7LN5TR53X57NZEVBNHHB5CCZQY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3151@github.com>
Subject: [quicwg/base-drafts] loss detection timer description could be simplified by definining a timer mode (#3151)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db24c5cdd502_8153fbf60acd96054672"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/r3_4t18tPCmmWeEvmn5U_5Zczyk>

In `SetLossDetectionTimer` we're setting the loss detection timer in order to:

- trigger an early retransmit (if we received gaps in the acknowledged packets) **or**
- trigger a PTO (if we only have a tail outstanding)

When the timer fires, in `OnLossDetectionTimeout`, we first need to figure out why we set the timer, and trigger an early retransmit or a PTO based on that.

I think the code would be easier if we save a "timer mode" `enum { EARLY_RETRANSMIT, PTO }` in `SetLossDetectionTimer`, and take action based on that mode in `OnLossDetectionTimeout`.

@ianswett, @janaiyengar What do you think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3151

[quicwg/base-drafts] loss detection timer descrip… Marten Seemann
Re: [quicwg/base-drafts] loss detection timer des… ianswett
Re: [quicwg/base-drafts] loss detection timer des… ianswett
Re: [quicwg/base-drafts] loss detection timer des… Marten Seemann
Re: [quicwg/base-drafts] loss detection timer des… ianswett
Re: [quicwg/base-drafts] loss detection timer des… Jana Iyengar
Re: [quicwg/base-drafts] loss detection timer des… ianswett
Re: [quicwg/base-drafts] loss detection timer des… Lars Eggert
Re: [quicwg/base-drafts] loss detection timer des… ianswett
Re: [quicwg/base-drafts] loss detection timer des… ianswett