[quicwg/base-drafts] forbid empty NEW_TOKEN frames (#2977)
Marten Seemann <notifications@github.com> Sat, 17 August 2019 03:37 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C80D11200D5 for <quic-issues@ietfa.amsl.com>; Fri, 16 Aug 2019 20:37:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HP01LayLnCcl for <quic-issues@ietfa.amsl.com>; Fri, 16 Aug 2019 20:37:08 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E9658120096 for <quic-issues@ietf.org>; Fri, 16 Aug 2019 20:37:07 -0700 (PDT)
Date: Fri, 16 Aug 2019 20:37:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566013027; bh=qO7VanKxifcgJDBuxDBzuZbmaq6kIhZ67H4k/FU9D3o=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=oPrzm1/bhn3ARYckygIKmq1m+2zpNUy/8C+8p4k0WD1AgvufmlddFqt4DB1FzecLq 7SBd/xhL0ZLI8fTZ6FuBrXbMs0NrYjVhK1wtsbFcsuS3X056rxpp9oxfVgVO25DUjO dr9laXajiZWf6nAjSwrH6yav2ngMbSpDy/hdITzQ=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZHTFPRXS34SIBXEAN3MSUOHEVBNHHBZOCWUY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2977@github.com>
Subject: [quicwg/base-drafts] forbid empty NEW_TOKEN frames (#2977)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d577663d5b7_aad3fc2a40cd96489556"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/r7thy3x7ANlE2qleKPQj5M1PSOE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Aug 2019 03:37:10 -0000
If we allow empty NEW_TOKEN frames, the receiver would have to check that the token is not empty before saving and reusing it, so it seems slightly easier to forbid this nonsensical edge case. You can view, comment on, or merge this pull request online at: https://github.com/quicwg/base-drafts/pull/2977 -- Commit Summary -- * forbid empty NEW_TOKEN frames -- File Changes -- M draft-ietf-quic-transport.md (3) -- Patch Links -- https://github.com/quicwg/base-drafts/pull/2977.patch https://github.com/quicwg/base-drafts/pull/2977.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2977
- [quicwg/base-drafts] forbid empty NEW_TOKEN frame… Marten Seemann
- Re: [quicwg/base-drafts] forbid empty NEW_TOKEN f… Kazuho Oku
- Re: [quicwg/base-drafts] forbid empty NEW_TOKEN f… ianswett
- Re: [quicwg/base-drafts] forbid empty NEW_TOKEN f… Marten Seemann
- Re: [quicwg/base-drafts] forbid empty NEW_TOKEN f… martinduke
- Re: [quicwg/base-drafts] forbid empty NEW_TOKEN f… Martin Thomson
- Re: [quicwg/base-drafts] forbid empty NEW_TOKEN f… Marten Seemann
- Re: [quicwg/base-drafts] forbid empty NEW_TOKEN f… Martin Thomson