IETF Logo Mail Archive

Re: [quicwg/base-drafts] Simplify UpdateRtt pseudocode (#2610)

Lars Eggert <notifications@github.com> Fri, 12 April 2019 05:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A3A1412010C for <quic-issues@ietfa.amsl.com>; Thu, 11 Apr 2019 22:48:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.383
X-Spam-Level:
X-Spam-Status: No, score=-6.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 72KiDq8LXr9a for <quic-issues@ietfa.amsl.com>; Thu, 11 Apr 2019 22:48:18 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C18AA120103 for <quic-issues@ietf.org>; Thu, 11 Apr 2019 22:48:17 -0700 (PDT)
Date: Thu, 11 Apr 2019 22:48:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555048096; bh=D0gwJ0zqhTcWIqOq8SylRJnGs2yoG1RQckuGbjYjJVk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=EI+KaUQ18YxiunIxSfWOW0eLUZBVpONfOSsTeAJ54g5irN93yHQsemOVopZoajaF9 xhncva0u6GyGkdyy6CVMCP12G7UKAwW54fXa4BfqT9blItHAXIkpQrbe/wqH/4trvu VtRwgZLY2JaaHKx9BEaVVwi9X4HhP4O3DvcI4UHM=
From: Lars Eggert <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd5ef5b29fe47764092a5a1f43700e6cb78bdfc6992cebabd592092a169ce19c5c948@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2610/review/225904758@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2610@github.com>
References: <quicwg/base-drafts/pull/2610@github.com>
Subject: Re: [quicwg/base-drafts] Simplify UpdateRtt pseudocode (#2610)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb026a0b1935_79253face8cd45b81486c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: larseggert
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/r9kM8Ran6I__civqe9LRYqMvNRA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Apr 2019 05:48:20 -0000

larseggert commented on this pull request.



> @@ -1101,22 +1101,24 @@ OnAckReceived(ack, pn_space):
 
 
 UpdateRtt(latest_rtt, ack_delay):
+  if (smoothed_rtt == 0):
+    // First RTT sample.

Shouldn't you adjust by `ack_delay` here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2610#pullrequestreview-225904758

v2.23.0 | Report a Bug | By Email