Re: [quicwg/base-drafts] Consider making h3 frame types varint (#2253)

Lucas Pardue <notifications@github.com> Wed, 06 February 2019 01:31 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 28A4A128CE4 for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 17:31:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.935
X-Spam-Level:
X-Spam-Status: No, score=-5.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_SUMOF=5, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8zrEFDcgMdSh for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 17:31:44 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DA90F128B01 for <quic-issues@ietf.org>; Tue, 5 Feb 2019 17:31:43 -0800 (PST)
Date: Tue, 05 Feb 2019 17:31:43 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549416703; bh=nYxR/gtnHQZP0qNOIufm9ahg7OJYzjRS9lgGCnFGvV4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Bgk7imM/OZqC9gqsJ9p4r6TR8Mn3KcjuNYMFIa1UuGtjDCoJ1cUcErcqQlYdWNr6G K5Cnc7n8Y/K7i9NFA07lmfPPglyBDfKwy7+w0nqldUm3Akn8SL+Oie3WDU7cgc8vbv 7lyaAH3I+JuLukItNwngDOEnktAqroFKlecpxDbQ=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab342d17dc85487eb2141550c16dcde4b4c211de7892cf000000011871faff92a169ce17792cde@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2253/460870715@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2253@github.com>
References: <quicwg/base-drafts/issues/2253@github.com>
Subject: Re: [quicwg/base-drafts] Consider making h3 frame types varint (#2253)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5a38ff3219f_38453fe1a2cd45c41073f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rGRoNp4PDtu37Ylck9NXcPEYd08>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 01:31:45 -0000

If we varint all the things, how likely is it that malformed frames occur? 

Many frames carry just a varint payload, so malformed seems mostly to be that frame length (i.e. payload length) mismatches the sum of received payload parts.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2253#issuecomment-460870715