IETF Logo Mail Archive

Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)

Marten Seemann <notifications@github.com> Tue, 05 November 2019 16:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C17E12001A for <quic-issues@ietfa.amsl.com>; Tue, 5 Nov 2019 08:49:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Yi2yEl5S87t for <quic-issues@ietfa.amsl.com>; Tue, 5 Nov 2019 08:49:48 -0800 (PST)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E7BF1200C3 for <quic-issues@ietf.org>; Tue, 5 Nov 2019 08:49:48 -0800 (PST)
Received: from github-lowworker-275fa97.va3-iad.github.net (github-lowworker-275fa97.va3-iad.github.net [10.48.17.64]) by smtp.github.com (Postfix) with ESMTP id 231CCA1DAF for <quic-issues@ietf.org>; Tue, 5 Nov 2019 08:49:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572972587; bh=ZsqC4XNl7D6/mQqODK5AaBAWtsZGk5NLYBtAZrTu4YM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ux2PosbCV5ODcO2cZsoueeMcuJYdS6hyaFA+mO9ujoIhY6Tg3oXIy4BoTndIBQUHg CgzMI3CRr2JpBPGZME0yLi/NGAbwywDLHqBXPof+pwK/HAlcAYcelM8c3NNz5Z+HPe UTZ8sb7M326SuFIJzuwLNJvxkD5vjqL8u16xWQR0=
Date: Tue, 05 Nov 2019 08:49:47 -0800
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK75DDHQXIWEN72LAJ53Z3NKXEVBNHHB5UBVKI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3186/c549899953@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3186@github.com>
References: <quicwg/base-drafts/pull/3186@github.com>
Subject: Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc1a82b131ea_41153ff1530cd9685639a3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rKEKljx5T7oxcxnZ5zrLvlvx8Qg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Nov 2019 16:49:50 -0000

@ianswett I don't think we ever actually discussed this in the working group. If I remember correctly, using two error codes was a suggestion that came up on my original PR, and then the editors decided in Cupertino that I should update the PR accordingly.

Actually, I'd prefer to take the principled approach, and just use FRAME_ENCODING_ERROR wherever possible.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3186#issuecomment-549899953

v2.29.0 | Report a Bug | By Email | System Status