Re: [quicwg/base-drafts] Handling of corrupt Retry packets (#3014)

Nick Banks <notifications@github.com> Wed, 25 September 2019 14:31 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E96A1200C4 for <quic-issues@ietfa.amsl.com>; Wed, 25 Sep 2019 07:31:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.495
X-Spam-Level:
X-Spam-Status: No, score=-6.495 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HE7jb-88X1as for <quic-issues@ietfa.amsl.com>; Wed, 25 Sep 2019 07:31:20 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6873512006E for <quic-issues@ietf.org>; Wed, 25 Sep 2019 07:31:20 -0700 (PDT)
Received: from github-lowworker-a6a2749.va3-iad.github.net (github-lowworker-a6a2749.va3-iad.github.net [10.48.16.62]) by smtp.github.com (Postfix) with ESMTP id 764088C0549 for <quic-issues@ietf.org>; Wed, 25 Sep 2019 07:31:19 -0700 (PDT)
Date: Wed, 25 Sep 2019 07:31:19 -0700
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK47Q3GUNH5UGTFEYRV3TC5MPEVBNHHB2TYBKQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3014/535051316@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3014@github.com>
References: <quicwg/base-drafts/issues/3014@github.com>
Subject: Re: [quicwg/base-drafts] Handling of corrupt Retry packets (#3014)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d8b7a37679cc_f4a3f8aa8ecd96c15055e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rN5QyIjN7G2fsvCaoy1Z1-HIOlM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Sep 2019 14:31:22 -0000

I'm not exactly what more you need than "this is expensive". Obviously the HW can't be built and then we decide what to do. I just did a quick and dirty perf test (not sure if RSS was completely configured), and these were some numbers of our software QUIC stack for a CPU limited sender:
```
Encryption          45.32%
UDP Send            36.86%
Stream Data Copy     6.07%
ACK Processing       3.65%
```
The leftovers are for various smaller things. This is also on a machine that doesn't support all the HW offloads we support in Windows, so the UDP number can go down (drastically, giving numbers closer to the one I gave before). Also, while I am no crypto expert, I do not believe Windows bcrypt APIs are overly costly, compared to other libraries.

I know UDP has been expensive in the past, but that's no longer the case. I feel we should not use that past behavior as an excuse to default to computationally expensive solutions, where other solutions are available.

And again, like mikkelfj said you can't directly compare HW and SW solutions very well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3014#issuecomment-535051316