Re: [quicwg/base-drafts] Unknown transport parameters cannot be ignored if no length is provided (#1661)

Mike Bishop <notifications@github.com> Tue, 14 August 2018 16:53 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5FE48130DD3 for <quic-issues@ietfa.amsl.com>; Tue, 14 Aug 2018 09:53:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W6o4stBbi1_1 for <quic-issues@ietfa.amsl.com>; Tue, 14 Aug 2018 09:53:37 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C975128CFD for <quic-issues@ietf.org>; Tue, 14 Aug 2018 09:53:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=SeosB00O/xHjZNUGMy3dv9E6ERo=; b=UcUf1++J2107RpUC Ql0tHrNtKG7bU6i+ymK6rG6su48addjWJkoAX82wloeW2OFRSaMTBcpE5/6ZkGVz HuB8NzOhJplyvFUBIr2RgLmG/pK4kenm0vLxO00GfsIubG21ESu3xPO/XCoGF7As deAdiSqS03XG8jtFmHflOw4dfjM=
Received: by filter0212p1iad2.sendgrid.net with SMTP id filter0212p1iad2-30025-5B73090C-1D 2018-08-14 16:53:32.464171728 +0000 UTC m=+60952.213674077
Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0020p1iad2.sendgrid.net (SG) with ESMTP id 1RS7xaaYR7On2E55KWOZAw for <quic-issues@ietf.org>; Tue, 14 Aug 2018 16:53:32.576 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id 7C8983E0D33 for <quic-issues@ietf.org>; Tue, 14 Aug 2018 09:53:32 -0700 (PDT)
Date: Tue, 14 Aug 2018 16:53:32 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab69a2332704c1fcf0aca9e5ed6b981469deb5f6f292cf00000001178acb0c92a169ce14e34149@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1661/412941132@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1661@github.com>
References: <quicwg/base-drafts/issues/1661@github.com>
Subject: Re: [quicwg/base-drafts] Unknown transport parameters cannot be ignored if no length is provided (#1661)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b73090c79a90_59c63f8d3bad45b4187834"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0rH4oLMPLZESbCV6R1qZhGccbl39WwHbMJed bFGZddK27fe/vaau3SmeyIu2eSWxw0rEDdg1IL6pcS/QQVpCcoInKovGJJaSrYXjBJR3Wi6WQFk9oh 3hzdxAxFDeraqkSsOL4GGpMJNMopCQoxAPLaoDfneuUW0sVT3nhmtESkSDI4NVSfpcWozPzA4hrrI4 A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rQHfk1OISNjI2KdwmKgEjlQi70U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Aug 2018 16:53:38 -0000

What you missed is that the TLS presentation language makes length prefixes implicit.  The generic definition for a TransportParameter is:

```
   struct {
      TransportParameterId parameter;
      opaque value<0..2^16-1>;
   } TransportParameter;
```

That means that `value` is a sequence of bytes with a two-byte length prefix.  Everything else defines the content of `value` for particular values of `parameter`.

Separately, while I agree that there's a dependency on the TLS *document* for the definition of the presentation language, there's actually no dependency on TLS *libraries* for generating this sequence of blobs.  It's a convenient notation for a binary structure, just as ABNF is a convenient notation for a text structure.  I'm with you that I wish it were a separate RFC rather than being a section in a TLS draft, but that's not the province of this WG.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1661#issuecomment-412941132