Re: [quicwg/base-drafts] QUIC's Initial Congestion Window specification is incorrect (#3997)

ianswett <notifications@github.com> Thu, 13 August 2020 20:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B85393A111A for <quic-issues@ietfa.amsl.com>; Thu, 13 Aug 2020 13:32:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dKuPMfjY43tH for <quic-issues@ietfa.amsl.com>; Thu, 13 Aug 2020 13:31:59 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CE3783A1110 for <quic-issues@ietf.org>; Thu, 13 Aug 2020 13:31:58 -0700 (PDT)
Received: from github-lowworker-9d2806a.ash1-iad.github.net (github-lowworker-9d2806a.ash1-iad.github.net [10.56.102.50]) by smtp.github.com (Postfix) with ESMTP id F19C834009A for <quic-issues@ietf.org>; Thu, 13 Aug 2020 13:31:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597350717; bh=/RJxzoYRdbH5EJXUOsLYWG1kiseoVToZx+d7qAyAEoI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=r6ALgKO7pPyeuNNJBJKaDh2NMIGUfdWpo0c1CILq8HdMDVKmnh/ZK3Cv+IX576OGz U6LC7uI0M0I40HAAgUrclnFfJFurX0C/yujWXznCtUQnO2IAsRjyKQTpu8vUK0xSxd 0MCSDjWv+k7d+2CBZe6JtDhOqEIFRtzrZgEsYEfU=
Date: Thu, 13 Aug 2020 13:31:57 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6IWVZ6I6SMIV3JKZF5IGCD3EVBNHHCQ5AU7A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3997/673695661@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3997@github.com>
References: <quicwg/base-drafts/issues/3997@github.com>
Subject: Re: [quicwg/base-drafts] QUIC's Initial Congestion Window specification is incorrect (#3997)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f35a33de1b77_799016f83728293"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rRQCgyNv0hi8gm7qQ5d1Q3l2I9M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2020 20:32:09 -0000

Recovery says "QUIC begins every connection in slow start with the congestion window set to an initial value."

There's no mention of updating the initial congestion window, so at the beginning of the connection is currently the only time it's set.

QUIC advises setting do not fragment, and UDP typically gets dropped instead of fragmented in my experience even without the flag set, so I believe that simplifies the situation.

Given that, along the lines of (iii), I can imagine one potential issue is if the initial window is set to a large value based on some past information and then the MTU is decreased in order to allow the handshake to complete.  Currently there's nothing saying that the IW should be re-calculated if the max packet size decreases during the handshake, and adding one would be along the lines of your second suggested option.

But I'm also fine with removing the twice max datagram size clause, but that seems like a larger departure from existing RFCs, which makes me hesitant.

https://github.com/quicwg/base-drafts/blob/master/draft-ietf-quic-recovery.md#initial-and-minimum-congestion-window-initial-cwnd

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3997#issuecomment-673695661