Re: [quicwg/base-drafts] Make RST_STREAM a bit on STREAM frame (#775)

ekr <notifications@github.com> Tue, 19 September 2017 04:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CDF261342B8 for <quic-issues@ietfa.amsl.com>; Mon, 18 Sep 2017 21:01:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.999
X-Spam-Level:
X-Spam-Status: No, score=-6.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qrc6h9HscifE for <quic-issues@ietfa.amsl.com>; Mon, 18 Sep 2017 21:01:31 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext1.iad.github.net [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2CD5112EC30 for <quic-issues@ietf.org>; Mon, 18 Sep 2017 21:01:31 -0700 (PDT)
Date: Mon, 18 Sep 2017 21:01:30 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1505793690; bh=QekSt1Shw3TnUad6uF56AoM12Qrnd+dyVW/epupkcik=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Z2KowdNd0g20HUZI0IwEKIMz9MR/I+ITP6nDsZQWMo1fIUxnF+uT74bjPdlqfiehD cCoouIT3DiHH7UYiCIE2dNpJPcA+zIXj9tLspSvRSP8f977kqCwy5xSTzxj29CxaUD zGzz9GcG74Njyq9UC5F1uuRINSum48vhCmSb9eMM=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8cd00eaaea6a3e2ce15338aa6ae3f76eab040cca92cf0000000115d8589a92a169ce0f6980d1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/775/330422776@github.com>
In-Reply-To: <quicwg/base-drafts/issues/775@github.com>
References: <quicwg/base-drafts/issues/775@github.com>
Subject: Re: [quicwg/base-drafts] Make RST_STREAM a bit on STREAM frame (#775)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59c0969a5a0f3_2db43ff6d968cf80502c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rTBkn4ZfLSCO3_wdcZya0cedxfQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2017 04:01:33 -0000

On Mon, Sep 18, 2017 at 3:19 PM, Ryan Hamilton <notifications@github.com>
wrote:

> When you receive a STREAM frame, don't you have to look up the stream in
> order to deliver the stream data? In other words, I'm surprised that it's
> any less work to handle receipt of a RST_STREAM frame than it is to handle
> receipt of a STREAM frame with a build-in RST_STREAM semantic. Would you
> like to have only one place in the code which does the stream id to stream
> lookup? (That place being receipt of a STREAM frame).
>

Yes. And I'd like to have it dispatch essentially anything of that type to
the stream.


> Keep in mind that depending on how you implement things, receipt of a
> WINDOW_UPDATE frame needs to frob the stream as does receipt of an ACK
> frame for a packet containing data sent by that stream.
>

Well, WINDOW_UPDATE is now MAX_DATA and MAX_STREAM_DATA, so it's ready to
be made a stream frame.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/775#issuecomment-330422776