Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5642312875B for ; Wed, 12 Dec 2018 23:02:07 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -9.459 X-Spam-Level: X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sRdtBVFisz1P for ; Wed, 12 Dec 2018 23:02:05 -0800 (PST) Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 942AF12426E for ; Wed, 12 Dec 2018 23:02:05 -0800 (PST) Date: Wed, 12 Dec 2018 23:02:04 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544684524; bh=r2am1IbuH4ksTUo68JG9LsOZWU+3xu1UaS3yXWwOJJs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BBeKLK9uVFMPGkGE1aYPCTZpcP2HqByTQmGuIXP8qeJLj+XQoPwqFzEVW475P30Kw 30G4JMTgxNCQ5I3Hc7B/V88A981oM2uDJheMWtHDRcI7LWLLy1ptWOCCPpzTtoyEAS CDNAtQe7KUigNobi3jdalvyypLoZe0Yr5Cbku0w4= From: Martin Thomson Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Clarify OnAckReceived pseudocode (#2140) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c1203ec9441a_6d73f808ced45bc98402b"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: martinthomson X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 07:02:07 -0000 ----==_mimepart_5c1203ec9441a_6d73f808ced45bc98402b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit martinthomson requested changes on this pull request. > @@ -720,9 +720,14 @@ Pseudocode for OnAckReceived and UpdateRtt follow: // ack-eliciting, update the RTT. if (sent_packets[ack.largest_acked] && sent_packets[ack.largest_acked].ack_eliciting): + largest_acked_packet = ack.largest_acked This doesn't work because the largest_acked in the ACK might be newly acknowledged, but not the largest ever acknowledged. ```suggestion if ack.largest_acked > largest_acked_packet: largest_acked_packet = ack.largest_acked ``` > latest_rtt = now - sent_packets[ack.largest_acked].time UpdateRtt(latest_rtt, ack.ack_delay) + // Process ECN information if present. + if (ACK frame contains ECN information): + ProcessECN(ack) This is a separate change. I think that you should make this a separate PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2140#pullrequestreview-184522784 ----==_mimepart_5c1203ec9441a_6d73f808ced45bc98402b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

@martinthomson requested changes on this pull request.

=0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
> @@ -720,9 +720,14 @@ Pseudocode for OnAckR=
eceived and UpdateRtt follow:=0D
     // ack-eliciting, update the RTT.=0D
     if (sent_packets[ack.largest_acked] &&=0D
         sent_packets[ack.largest_acked].ack_eliciting):=0D
+      largest_acked_packet =3D ack.largest_acked=0D
=0D

This doesn't work because the largest_acked in the ACK might be newly = acknowledged, but not the largest ever acknowledged.

=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-      largest_acked_packet =3D ack.largest_ac=
ked=0D
+      if ack.largest_acked > largest_acked_packet:=0D
+         largest_acked_packet =3D ack.largest_acked=0D
=0D =0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
>        latest_rtt =3D now - sent_packets[a=
ck.largest_acked].time=0D
       UpdateRtt(latest_rtt, ack.ack_delay)=0D
 =0D
+    // Process ECN information if present.=0D
+    if (ACK frame contains ECN information):=0D
+       ProcessECN(ack)=0D
=0D

This is a separate change. I think that you should make this a separa= te PR.

=0D =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or mute the thread.

= =0D =0D = ----==_mimepart_5c1203ec9441a_6d73f808ced45bc98402b--