Re: [quicwg/base-drafts] Do not allow ICMP PTB to increase PMTU (#2161)

Igor Lubashev <notifications@github.com> Fri, 14 December 2018 18:59 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0732A13125A for <quic-issues@ietfa.amsl.com>; Fri, 14 Dec 2018 10:59:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.459
X-Spam-Level:
X-Spam-Status: No, score=-4.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0BYlPuKHZFDp for <quic-issues@ietfa.amsl.com>; Fri, 14 Dec 2018 10:59:11 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02D7D131259 for <quic-issues@ietf.org>; Fri, 14 Dec 2018 10:59:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=hgKQKAigs9jWUO3xvv2jaq4CPe8=; b=tjgIyL2z6SorT4+j 8ALhw0gXD1X3b5TGufD6Rli01xYLpUpYPo+ol0Ggo6SHTWq5C7XP7e6kCv/wgETE xuqxwv/YBnOITj8Pv18NWmtARM29TuVQGm+zGPVVm14G6cBjvsIrCZZDumBHHWcq NnPQ4+7HQZxHwcIpVkH8pIAYGJo=
Received: by filter0518p1iad2.sendgrid.net with SMTP id filter0518p1iad2-6090-5C13FD7D-12 2018-12-14 18:59:09.788549206 +0000 UTC m=+74535.896596596
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0008p1iad2.sendgrid.net (SG) with ESMTP id miwD3uZrSDy_FVs5aKRTGw for <quic-issues@ietf.org>; Fri, 14 Dec 2018 18:59:09.771 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id C5EB5A801DF for <quic-issues@ietf.org>; Fri, 14 Dec 2018 10:59:09 -0800 (PST)
Date: Fri, 14 Dec 2018 18:59:09 +0000
From: Igor Lubashev <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba834acb35f04b2d0df03bbb0eef9d312b216f3d892cf00000001182bbf7d92a169ce174c2f88@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2161/c447421214@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2161@github.com>
References: <quicwg/base-drafts/pull/2161@github.com>
Subject: Re: [quicwg/base-drafts] Do not allow ICMP PTB to increase PMTU (#2161)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c13fd7dc39d6_4a793f82830d45b8227323"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: igorlord
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2K6I3xRvHy/bXfJiMvyvwqq1e8hZ5eUqQlDo iZdKEo8YBdZuxZ5UgRKYTnlr275F3pqDqaIQcO0flTr0vIkgGf+jYuTqdAqzzMsnb+WeHsMzVNyaaj jRS8lNNqV2JaAcmNNAQ9Jr3qGK60huFn+csgMwcWekw62NDsZIaY5obnZXunxMK+saeEwnHoDK/pbz 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rYCJ87MFX7n-No2X6KVx2a2XiHI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 18:59:13 -0000

@gorryfair, I like this suggestion -- not talking about ignoring ICMP messages but about not using ICMP messages to increase PMTU.  That would be very clear and concise.

Validation with at least IP addresses, transport (implicit in a QUIC spec), and ports is a matter for #2109, and it looks like it will be resolved exactly this way.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2161#issuecomment-447421214