Re: [quicwg/base-drafts] Move stream type into frame type (#1431)
Martin Thomson <notifications@github.com> Thu, 14 June 2018 01:28 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8D13130DC5 for <quic-issues@ietfa.amsl.com>; Wed, 13 Jun 2018 18:28:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HeDzKZO_ugnb for <quic-issues@ietfa.amsl.com>; Wed, 13 Jun 2018 18:28:52 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 84A1A127598 for <quic-issues@ietf.org>; Wed, 13 Jun 2018 18:28:52 -0700 (PDT)
Date: Wed, 13 Jun 2018 18:28:51 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528939731; bh=TqP9ZFpI+MNA5bJLgqZ7kGf0EZCBaKRpB+Lc7WuVQgI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=A/s7psIVdEGenC9h8Zo7bR/DCnNBGpr4QwM4U0PhbGRFaCBQz1kXAj4/7ZZjkeJ6G X6HwHX1eaCQxcGfqAYe3zWU5D0eda88NQV0e0u2Jdesr5FEyGkcyb4wGPRpW3/mqU5 vdsyxAXSknRhwXXNPuJNG+HrAEotpVdFOS7mb/3c=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3d75777a62ebc7d6763653e6e5a72c762ca7f73492cf00000001173986d392a169ce13b4e51c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1431/c397138052@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1431@github.com>
References: <quicwg/base-drafts/pull/1431@github.com>
Subject: Re: [quicwg/base-drafts] Move stream type into frame type (#1431)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b21c4d3c2159_50473fd835a0cf88165343"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rYYqznkSSRHuEcklWCdu7JpkKn8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 01:28:55 -0000
So I don't know for certain, I just had the numbers in the end. I suspect that it was just the extra code needed to pull two lots of two bits from the first octet. Obviously having an extra field is more work, but it was more costly than I anticipated. I probably have the code on a branch still... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1431#issuecomment-397138052
- Re: [quicwg/base-drafts] Move stream type into fr… Mike Bishop
- Re: [quicwg/base-drafts] Move stream type into fr… Mike Bishop
- Re: [quicwg/base-drafts] Move stream type into fr… Martin Thomson
- Re: [quicwg/base-drafts] Move stream type into fr… Martin Thomson
- Re: [quicwg/base-drafts] Move stream type into fr… Mike Bishop
- Re: [quicwg/base-drafts] Move stream type into fr… Lucas Pardue
- [quicwg/base-drafts] Move stream type into frame … Mike Bishop
- Re: [quicwg/base-drafts] Move stream type into fr… Martin Thomson
- Re: [quicwg/base-drafts] Move stream type into fr… MikkelFJ
- Re: [quicwg/base-drafts] Move stream type into fr… Mike Bishop
- Re: [quicwg/base-drafts] Move stream type into fr… MikkelFJ
- Re: [quicwg/base-drafts] Move stream type into fr… Martin Thomson
- Re: [quicwg/base-drafts] Move stream type into fr… ianswett
- Re: [quicwg/base-drafts] Move stream type into fr… Martin Thomson
- Re: [quicwg/base-drafts] Move stream type into fr… janaiyengar