Re: [quicwg/base-drafts] If PTO is armed for anti-deadlock, use now() (#3556)

Martin Thomson <notifications@github.com> Mon, 30 March 2020 22:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CCFFE3A14A2 for <quic-issues@ietfa.amsl.com>; Mon, 30 Mar 2020 15:32:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.5
X-Spam-Level:
X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2cHS9BnIG2DH for <quic-issues@ietfa.amsl.com>; Mon, 30 Mar 2020 15:32:05 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6CB3E3A14AC for <quic-issues@ietf.org>; Mon, 30 Mar 2020 15:32:05 -0700 (PDT)
Date: Mon, 30 Mar 2020 15:32:04 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585607524; bh=GTmBO6DaIoSavZtT3LlI4RaQyJ8FoQcvLqm1YFrYXlg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VdL8chY8X8r+vo/TsDbiitn2gjMa+siSCiU9+fsDgLgbNQBqmI2E0X91EbG6N3lk1 C6v6ZJ8WgCXYA/roqD3sVH1KMpYDjt4DxSWaBX7trCEzQun+0U3loP6mGgW1d0vTaG 5Wahh8KXJ6p8X3Jwk7YV33VqTRdYYocYXQSBlqeo=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZDWBO6WAPGPNN22A54RZKGJEVBNHHCGL7MQU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3556/review/384278968@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3556@github.com>
References: <quicwg/base-drafts/pull/3556@github.com>
Subject: Re: [quicwg/base-drafts] If PTO is armed for anti-deadlock, use now() (#3556)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e82736478aa7_3fee3fa5fd6cd9681228c1"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rafm-YJdRoLwdzU_3ugLG50z8xc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Mar 2020 22:32:07 -0000

@martinthomson commented on this pull request.

Consistency FTW :)

> +  if (sent_time == 0)
+    assert(!PeerNotAwaitingAddressValidation())
+    sent_time = now()
   loss_detection_timer.update(sent_time + timeout)

```suggestion
  if (sent_time != 0)
    loss_detection_timer.update(sent_time + timeout)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3556#pullrequestreview-384278968