Re: [quicwg/base-drafts] token-based greasing / initial packet protection (#3166)
Martin Thomson <notifications@github.com> Tue, 29 October 2019 23:36 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 932FC120098 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 16:36:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NLAq2bDN4Zre for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 16:36:40 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2991B12006D for <quic-issues@ietf.org>; Tue, 29 Oct 2019 16:36:40 -0700 (PDT)
Date: Tue, 29 Oct 2019 16:36:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572392198; bh=zvAj87TLVGkCMBOdtpA+Eruy0GuWvVQ/WoV9xL3AOxg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CFvzqt2EkpvvUKdtoLFkOO1q/0ZtjAEZUdbsmyXrm66/6k0O09ibG6Zsmy+964Xht SGUrPmQRqym0yR3oeHtckweChW0ZqgS77DCfrK4jkIRtYYQO53jUdwIU9dnrZaBabe D+Tkp36OEWluwyTGZc1Qt+oSYEOWdZ2i4UmVSQG4=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ5IKV4J5BYAYJMOWF3YYGZNEVBNHHB5HRKFQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3166/review/308895446@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3166@github.com>
References: <quicwg/base-drafts/pull/3166@github.com>
Subject: Re: [quicwg/base-drafts] token-based greasing / initial packet protection (#3166)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8cd0665e56_710b3fc82a4cd95c158896"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rmNfQtMx6Z7W0FD0t8103Bb64QQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 23:36:42 -0000
martinthomson commented on this pull request. > +NEW_TOKEN frame, the server generates the alternative initial salt by calling a +pseudo-random function, embeds that initial salt into the token which is then +encrypted, and sends a NEW_TOKEN frame that comprises of the generated token and +the alternative initial set. + +When the client reconnects to the server by using the provided token and the +alternative initial set, the server first checks if the version number field of +the incoming packet contains one of the alternative version numbers it +advertises, then if that is the case, applies the corresponding packet type +modifier to recover the correct packet type. If the recovered packet type is an +Initial packet and that packet contains a NEW_TOKEN token, the server decrypts +the embedded token and recovers the alternative initial salt, uses that to +decrypt the payload of the Initial packet. + +When the server is incapable of determining the alternative initial salt, it can +send a Version Negotiation packet that instructs the client to use the default Yes, this offers an almost trivial downgrade attack, but this isn't a scenario that we agreed to cover. It does seem to be a little bit *too* trivial an attack though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3166#discussion_r340374998
- [quicwg/base-drafts] token-based greasing (#3166) Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing (#3… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Marten Seemann
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… David Schinazi
- Re: [quicwg/base-drafts] token-based greasing / i… Mike Bishop
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Martin Thomson
- Re: [quicwg/base-drafts] token-based greasing / i… David Schinazi
- Re: [quicwg/base-drafts] token-based greasing / i… Martin Thomson
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Martin Thomson
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… MikkelFJ
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Martin Thomson
- Re: [quicwg/base-drafts] token-based greasing / i… Mike Bishop
- Re: [quicwg/base-drafts] token-based greasing / i… Mike Bishop
- Re: [quicwg/base-drafts] token-based greasing / i… MikkelFJ
- Re: [quicwg/base-drafts] token-based greasing / i… David Schinazi
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… MikkelFJ
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Martin Thomson
- Re: [quicwg/base-drafts] token-based greasing / i… Kazuho Oku
- Re: [quicwg/base-drafts] token-based greasing / i… Mike Bishop
- Re: [quicwg/base-drafts] token-based greasing / i… Mike Bishop
- Re: [quicwg/base-drafts] token-based greasing / i… Martin Thomson
- Re: [quicwg/base-drafts] token-based greasing / i… Martin Thomson