IETF Logo Mail Archive

Re: [quicwg/base-drafts] Retransmit server initial upon second Initial (#3080)

Martin Thomson <notifications@github.com> Fri, 11 October 2019 03:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E15C71200F7 for <quic-issues@ietfa.amsl.com>; Thu, 10 Oct 2019 20:13:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1CqIENMpzc46 for <quic-issues@ietfa.amsl.com>; Thu, 10 Oct 2019 20:13:10 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 15B231200D7 for <quic-issues@ietf.org>; Thu, 10 Oct 2019 20:13:10 -0700 (PDT)
Date: Thu, 10 Oct 2019 20:13:09 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570763589; bh=oLCu3KKrYvzfmdukZDx7GTWNkYr3C4JxX6pC4DgMcLY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AtFaRjdbZnosAJKEXoADs46Eyq8a7kOOeGq9tgSD+RHIOZR2XHSBrQYhTdtMaEsgg KnaPsTHd71e46fWjepn5NS1V5ec+GO11tMLxF9w15+uLz1Wj3p0/ZbAw6uYriB6NoC m4cMixBIjZJRZYD3cMSTGW0yHUN0MDbtJNrjqr0o=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5YIO737ESW6IWLNVV3VUS4LEVBNHHB37QS2E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3080/review/300448763@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3080@github.com>
References: <quicwg/base-drafts/pull/3080@github.com>
Subject: Re: [quicwg/base-drafts] Retransmit server initial upon second Initial (#3080)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d9ff34552025_47133f85786cd968284370"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rsoMI_z_lQHbzChbQzhg9Edwi-c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Oct 2019 03:13:12 -0000

martinthomson commented on this pull request.



> @@ -508,6 +508,12 @@ until it is certain that the server has finished its address validation
 probe timer if the client has not received an acknowledgement for one of its
 Handshake or 1-RTT packets.
 
+When a server receives duplicate CRYPTO data in an Initial packet after sending
+its Initial flight, it can assume the client did not receive all Initial CRYPTO
+data. To speed handshake completion, it SHOULD retransmit all unacknowledged
+Initial CRYPTO data subject to the path validation limits.  After doing so,
+the PTO is re-armed.

The way I read this, it says that you retransmit then you re-arm the PTO timer.

I think that you mean to say that when the path is validated, you can re-arm the PTO timer after retransmitting the CRYPTO data, but that's not what it says.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3080#discussion_r333811560

v2.23.0 | Report a Bug | By Email