Re: [quicwg/base-drafts] Bikeshed Required Insert Count encoding. (#2366)
afrind <notifications@github.com> Mon, 28 January 2019 04:36 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B849130F2D for <quic-issues@ietfa.amsl.com>; Sun, 27 Jan 2019 20:36:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.935
X-Spam-Level:
X-Spam-Status: No, score=-5.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rvsPDorIQrzf for <quic-issues@ietfa.amsl.com>; Sun, 27 Jan 2019 20:36:46 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 403F0130ED9 for <quic-issues@ietf.org>; Sun, 27 Jan 2019 20:36:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=3MvL/68um2e4UBuvkPEiQZyZajk=; b=BTfr8KDMNDfVXfzm xYXKn1r+tkkB9JyK3rKTIscFpbfjPHGvcj1OOusuDee9xMhZ06KjcTaiR28fEoUa iJangr5FiW0RUS1bGlYAMk1W7CpzmMwGsbtUxDEAKNDegxTj6IlH5Oeyy71plWeL G3KD0DV6I0ZW5C85JbeqDsltf5k=
Received: by filter0351p1iad2.sendgrid.net with SMTP id filter0351p1iad2-15608-5C4E86DD-5 2019-01-28 04:36:45.048776114 +0000 UTC m=+190463.001396941
Received: from github-lowworker-dcd58f3.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id vOANHwlzQoCUUqMEUzHiMw for <quic-issues@ietf.org>; Mon, 28 Jan 2019 04:36:45.100 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dcd58f3.cp1-iad.github.net (Postfix) with ESMTP id 0A339240BFE for <quic-issues@ietf.org>; Sun, 27 Jan 2019 20:36:45 -0800 (PST)
Date: Mon, 28 Jan 2019 04:36:45 +0000
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6fa622d0f81bf3393db94569c65f59f57a299adc92cf00000001186648dd92a169ce17faf23c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2366/review/196874320@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2366@github.com>
References: <quicwg/base-drafts/pull/2366@github.com>
Subject: Re: [quicwg/base-drafts] Bikeshed Required Insert Count encoding. (#2366)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4e86dd86ca_34493f8a38ed45c0906d4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3AlThLBvT5duuZZwXcdkZSqQNaUMrAIcHuxu SngP87MoBl5VhUARNPfC7ScfgnBrWmjQer6pI5qlyHQPrONS4HMRXRFzSVXlOe8AV5XIYVDJLdil3g ZiuS6rgquyw52fLaKdNhsDAp4KleJ36mIu0urg/hw/TANzDmq5i4bka7IA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rx8g8VNq0vWoMktm48CAyd2XccQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jan 2019 04:36:48 -0000
afrind commented on this pull request. > ~~~ - EncodedInsertCount = (ReqInsertCount mod (2 * MaxEntries)) + 1 + if ReqInsertCount == 0: + EncodedInsertCount = 0 nit: is the spacing identical in the if and else branches? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2366#pullrequestreview-196874320