Date: Mon, 28 Jan 2019 04:36:45 +0000 (UTC)
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab6fa622d0f81bf3393db94569c65f59f57a299adc92cf00000001186648dd92a169ce17faf23c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2366/review/196874320@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2366@github.com>
References: <quicwg/base-drafts/pull/2366@github.com>
Subject: Re: [quicwg/base-drafts] Bikeshed Required Insert Count encoding.
 (#2366)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c4e86dd86ca_34493f8a38ed45c0906d4";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rx8g8VNq0vWoMktm48CAyd2XccQ>

----==_mimepart_5c4e86dd86ca_34493f8a38ed45c0906d4
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

afrind commented on this pull request.



>  
 ~~~
-   EncodedInsertCount = (ReqInsertCount mod (2 * MaxEntries)) + 1
+   if ReqInsertCount == 0:
+      EncodedInsertCount = 0

nit: is the spacing identical in the if and else branches?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2366#pullrequestreview-196874320
----==_mimepart_5c4e86dd86ca_34493f8a38ed45c0906d4
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@afrind</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2366#discussion_r251280870">draft-ietf-quic-qpack.md</a>:</p>
<pre style='color:#555'>&gt;  
 ~~~
-   EncodedInsertCount = (ReqInsertCount mod (2 * MaxEntries)) + 1
+   if ReqInsertCount == 0:
+      EncodedInsertCount = 0
</pre>
<p>nit: is the spacing identical in the if and else branches?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2366#pullrequestreview-196874320">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkqyLOWtZT32Fo22ssJJXAkZ7ovtWGks5vHn5dgaJpZM4aPJYD">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq_9haiZgGkr_fYmyIZy6q192YkQCks5vHn5dgaJpZM4aPJYD.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@afrind commented on #2366"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2366#pullrequestreview-196874320"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2366#pullrequestreview-196874320",
"url": "https://github.com/quicwg/base-drafts/pull/2366#pullrequestreview-196874320",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c4e86dd86ca_34493f8a38ed45c0906d4--