Re: [quicwg/base-drafts] Add bidirectional streams on top of unidirectional (#720)

Mike Bishop <notifications@github.com> Thu, 17 August 2017 17:10 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 31347132359 for <quic-issues@ietfa.amsl.com>; Thu, 17 Aug 2017 10:10:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.799
X-Spam-Level:
X-Spam-Status: No, score=-4.799 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gb71IzBacvSQ for <quic-issues@ietfa.amsl.com>; Thu, 17 Aug 2017 10:10:52 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 319A51323F7 for <quic-issues@ietf.org>; Thu, 17 Aug 2017 10:10:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=8sP2eVMKBkQtEaakornWrcg0qUc=; b=fpSPhx64uhxEJxVr gYbPBGLDq9COME9HVlmkFHC13dKW9Bl8XBGzXkBVc9Z7VebHR7FSqbIiIoyXwihA lkrcpuuY50ulcDVLR7ifX6zTTauFolWCaofm3LBuMEiBKk3Z+gACvJJ71S+oBxcr LCL3aj3QFA2ZiFnOMazmk7AKVWE=
Received: by filter0949p1mdw1.sendgrid.net with SMTP id filter0949p1mdw1-22602-5995CE19-1D 2017-08-17 17:10:49.257551966 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0030p1mdw1.sendgrid.net (SG) with ESMTP id uAjx6AX6Su-8v-KliOh7Sg for <quic-issues@ietf.org>; Thu, 17 Aug 2017 17:10:49.225 +0000 (UTC)
Date: Thu, 17 Aug 2017 17:10:49 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abbf432717d1fdf6c66a300c8c740b67c7c0083dfa92cf0000000115ad901892a169ce0edf651b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/720/review/56992835@github.com>
In-Reply-To: <quicwg/base-drafts/pull/720@github.com>
References: <quicwg/base-drafts/pull/720@github.com>
Subject: Re: [quicwg/base-drafts] Add bidirectional streams on top of unidirectional (#720)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5995ce18e0ea3_25e73fa5de7b1c2c11508f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0uF+Xi5DlDp+wqjPKTJAboKdkWUOKt89iDE2 F7KnzJ5i2Ioc+DqdHsIiZBuA8ilxPRQAayithh+EWbpF4AxJ4VsoxgZrXPmm8yfAcEnBEmh4wFvwK5 tAUKM6d4t54ilgyfYWEbhiVN8D/myiUsK4Hwpz3BIbMWbgKSxqdfajggbzJbAN/lfw1Mzf/tiWrDS6 c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/s192sPlRIKhJ-qDQvf-sDy69ykY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Aug 2017 17:10:55 -0000

MikeBishop commented on this pull request.



> +This document doesn't proscribe the use of the Related Stream ID field, leaving
+decisions about the semantics of related streams to protocols that use QUIC.
+Protocols that use QUIC MUST either define the semantics of related streams or
+prohibit the use of the Related Stream ID field.  Protocols MAY define other
+uses for the Related Stream ID field, but are advised that complex relationships
+between streams could be poorly supported in generic QUIC implementations.  The
+INVALID_RELATED_STREAM error code can be used by protocols to signal receipt of
+invalid Related Stream ID field values, unless the protocol defines a more
+specific error code for the circumstances.
+
+The Related Stream ID for a stream only needs to be sent once for each (allowing
+for retransmissions due to loss).  Sending the field on all stream frames with
+an offset of 0 ensures that the value is received without duplicating the field
+unnecessarily.  If the value of the Related Stream ID changes for a stream, the
+endpoint that receives the conflicting value MUST treat this as a connection
+error of type INVALID_RELATED_STREAM.

I don't think the updated text explicitly says whether **NOT** setting the `R` bit on subsequent frames constitutes a change.  I think the simplest way to scope it is that if there's a related stream, `R` MUST be set on the zero-offset frame and MAY be set on other frames, but the value of the Related Stream ID MUST NOT change on subsequent frames if `R` is set.

If you receive frames out-of-order and `R` is set, you have the info early; if it's *not* set then you can't do anything with that yet because it might still have been set on some other frame.  You still have to wait for the zero-offset frame to conclude that it will never be set.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/720#discussion_r133773301