IETF Logo Mail Archive

Re: [quicwg/base-drafts] Reorganize ACK section (#2197)

Christian Huitema <notifications@github.com> Mon, 17 December 2018 03:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E69A12D4F2 for <quic-issues@ietfa.amsl.com>; Sun, 16 Dec 2018 19:40:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.459
X-Spam-Level:
X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OnwQs7H78ETY for <quic-issues@ietfa.amsl.com>; Sun, 16 Dec 2018 19:40:47 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A7FF61286E7 for <quic-issues@ietf.org>; Sun, 16 Dec 2018 19:40:47 -0800 (PST)
Date: Sun, 16 Dec 2018 19:40:46 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545018046; bh=dIeVuqFKEfaV2CqWIrZMLoixzZ2Y+SddEnSzWq4f+RU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RNUAbveK/c2r2Oi9U4tljunxEDN8khlIgBgn7ca8ZwgLQ8+w0sp3/aySHo+dOHDM9 xcnaLV7gohBT+C57YSvoWaToCMh1p1/K0pWgph5RYJHUxIz04JDQF3ZwxqMF0vKhfH K5a1ay6yZtVz9LCTg7430/H3+s/hkrlVim01MlB4=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab323ee1fecbe0b5d166c82b4179e464372651c73492cf00000001182edcbe92a169ce17565ed9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2197/review/185431063@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2197@github.com>
References: <quicwg/base-drafts/pull/2197@github.com>
Subject: Re: [quicwg/base-drafts] Reorganize ACK section (#2197)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c171abea72d0_69963fa611cd45b4263910"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/s1P9Sb8_kTuGYJn1K5aG73uq5pA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Dec 2018 03:40:49 -0000

huitema commented on this pull request.



> @@ -2841,23 +2841,24 @@ needing acknowledgement are received.  The sender can use the receiver's
 Strategies and implications of the frequency of generating acknowledgments are
 discussed in more detail in {{QUIC-RECOVERY}}.
 
-To limit ACK Blocks to those that have not yet been received by the sender, the
-receiver SHOULD track which ACK frames have been acknowledged by its peer.  Once
-an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be
-acknowledged again.
+To limit the ranges of acknowledged packet numbers to those that have not yet
+been received by the sender, the receiver SHOULD track which ACK frames have
+been acknowledged by its peer.  Once an ACK frame has been acknowledged, the
+packets it acknowledges SHOULD NOT be acknowledged again.

How about: ... _Once an ACK frame has been acknowledged, it is RECOMMENDED to not repeat acknowledgement of the same packets._ The point is, there is no harm whatsoever in repeating the range multiple times, but it is good practice to keep ACK frames short.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2197#discussion_r242018813

v2.40.4 | Report a Bug | By Email | System Status