Re: [quicwg/base-drafts] Define stream limits as counts (#1906)

[Marten Seemann <[e-mail]>]

marten-seemann approved this pull request.



>  
 : The initial maximum bidirectional streams parameter contains the initial
   maximum number of bidirectional streams the peer may initiate, encoded as an
   unsigned 16-bit integer.  If this parameter is absent or zero, bidirectional
-  streams cannot be created until a MAX_STREAM_ID frame is sent.  Setting this
-  parameter is equivalent to sending a MAX_STREAM_ID ({{frame-max-stream-id}})
-  immediately after completing the handshake containing the corresponding Stream
-  ID. For example, a value of 0x05 would be equivalent to receiving a
-  MAX_STREAM_ID containing 16 when received by a client or 17 when received by a
-  server.
+  streams cannot be created until a MAX_STREAMS frame is sent.  Setting this

what about: s/streams cannot be created/the peer cannot open bidirectional streams/

>  
 : The initial maximum unidirectional streams parameter contains the initial
   maximum number of unidirectional streams the peer may initiate, encoded as an
   unsigned 16-bit integer.  If this parameter is absent or zero, unidirectional
-  streams cannot be created until a MAX_STREAM_ID frame is sent.  Setting this
-  parameter is equivalent to sending a MAX_STREAM_ID ({{frame-max-stream-id}})
-  immediately after completing the handshake containing the corresponding Stream
-  ID. For example, a value of 0x05 would be equivalent to receiving a
-  MAX_STREAM_ID containing 18 when received by a client or 19 when received by a
-  server.
+  streams cannot be created until a MAX_STREAMS frame is sent.  Setting this

same here

>  
-The MAX_STREAM_ID frame (type=0x06) informs the peer of the maximum stream ID
-that they are permitted to open.
+The MAX_STREAMS frame (type=0x1c and 0x1d) informs the peer of the number of
+streams they are permitted to open.  A MAX_STREAMS frame with a type of 0x1c

s/they are/it is/

>  
-A peer MUST NOT initiate a stream with a higher stream ID than the greatest
-maximum stream ID it has received.  An endpoint MUST terminate a connection with
-a STREAM_ID_ERROR error if a peer initiates a stream with a higher stream ID
-than it has sent, unless this is a result of a change in the initial limits (see
-{{zerortt-parameters}}).
+A peer MUST NOT initiate a stream with a higher stream ID than the largest limit
+it has received permits.  For instance, a server that receives a unidirectional
+stream limit of 4 is permitted to open stream 15, but not stream 19.  An

Maybe it's clearer if we enumerate the streams, e.g. "... is permitted to open streams 3, 7, 11 and 15, but not stream 19".

>  
 : The initial maximum bidirectional streams parameter contains the initial
   maximum number of bidirectional streams the peer may initiate, encoded as an
   unsigned 16-bit integer.  If this parameter is absent or zero, bidirectional
-  streams cannot be created until a MAX_STREAM_ID frame is sent.  Setting this
-  parameter is equivalent to sending a MAX_STREAM_ID ({{frame-max-stream-id}})
-  immediately after completing the handshake containing the corresponding Stream
-  ID. For example, a value of 0x05 would be equivalent to receiving a
-  MAX_STREAM_ID containing 16 when received by a client or 17 when received by a
-  server.
+  streams cannot be created until a MAX_STREAMS frame is sent.  Setting this
+  parameter is equivalent to sending a MAX_STREAMS ({{frame-max-streams}}) of
+  the corresponding type immediately after completing the handshake.

Since you removed the example for the encoding here, should we say "equivalent to sending a MAX_STREAMS of the corresponding type with the same value..."?

>  
 : A variable-length integer indicating the offset of the stream at which the
   blocking occurred.
 
 
-## STREAM_ID_BLOCKED Frame {#frame-stream-id-blocked}
+## STREAMS_BLOCKED Frame {#frame-streams-blocked}
+
+A sender SHOULD send a STREAMS_BLOCKED frame (type=0x1e or 0x1f) when it wishes
+to open a stream, but is unable to due to the maximum stream ID limit set by its
+peer (see {{frame-max-streams}}).  A STREAMS_BLOCKED frame of type 0x1e
+indicates a problem with the limit on bidirectional streams; a STREAMS_BLOCKED

s/a problem with the limit on/reaching the limit of/g

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1906#pullrequestreview-168195382