Re: [quicwg/base-drafts] handle reordered NEW_CONNECTION_ID frames (#3202)

ianswett <notifications@github.com> Thu, 07 November 2019 14:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E33A120288 for <quic-issues@ietfa.amsl.com>; Thu, 7 Nov 2019 06:10:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TPXxVHeZBi_i for <quic-issues@ietfa.amsl.com>; Thu, 7 Nov 2019 06:10:14 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7505312004C for <quic-issues@ietf.org>; Thu, 7 Nov 2019 06:10:14 -0800 (PST)
Received: from github-lowworker-5fb2734.va3-iad.github.net (github-lowworker-5fb2734.va3-iad.github.net [10.48.19.27]) by smtp.github.com (Postfix) with ESMTP id 6CFB3C607AB for <quic-issues@ietf.org>; Thu, 7 Nov 2019 06:10:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573135813; bh=8dPkLibKlPw8kZPzEfL0JsAEROBr0BU9oqOLSvfZgbo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Di4Bv6AVK1epYX0XEMKJyrIApSHseI7c7SGbO6T59b3RpsIfYcnDvP2QRk4MvR3Sa HYT3RCaCn9ueXNM7HrNCEJ3JVsG2UvMuaTtoC4OSuzKe8RK7TfAeNGhxBEjGDWzrgf +/lwaVBTRTtBIJVlX/ZfXib5CMRu92gbQWXmf2kE=
Date: Thu, 07 Nov 2019 06:10:13 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZIFOK5UMIICVVJKNF32FMELEVBNHHB532OGU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3202/review/313363137@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3202@github.com>
References: <quicwg/base-drafts/pull/3202@github.com>
Subject: Re: [quicwg/base-drafts] handle reordered NEW_CONNECTION_ID frames (#3202)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc425c55ddf9_6d843fd06b8cd9641776ae"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/sB68zps-ACuwwcbGpWRKO9p6ZYU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Nov 2019 14:10:16 -0000

ianswett approved this pull request.

Small editorial suggestion, but LG

> @@ -5398,6 +5398,10 @@ and preferred_address transport parameter connection IDs.  The peer SHOULD
 retire the corresponding connection IDs and send the corresponding
 RETIRE_CONNECTION_ID frames in a timely manner.
 
+An endpoint that receives a NEW_CONNECTION_ID frame with a sequence number
+smaller than the Retire Prior To field of a NEW_CONNECTION_ID frame received

```suggestion
smaller than the Retire Prior To field of a previously received NEW_CONNECTION_ID
```

> @@ -5398,6 +5398,10 @@ and preferred_address transport parameter connection IDs.  The peer SHOULD
 retire the corresponding connection IDs and send the corresponding
 RETIRE_CONNECTION_ID frames in a timely manner.
 
+An endpoint that receives a NEW_CONNECTION_ID frame with a sequence number
+smaller than the Retire Prior To field of a NEW_CONNECTION_ID frame received
+before, MUST immediately send a corresponding RETIRE_CONNECTION_ID frame.

```suggestion
frame MUST immediately send a corresponding RETIRE_CONNECTION_ID frame.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3202#pullrequestreview-313363137